1144138 - Treeherder client should have a timeout set

Status: RESOLVED FIXED

(Tree Management Graveyard :: Treeherder: Client Libraries, defect)

Description

[William Lachance (:wlach)]

We currently always use httplib's default timeout, which I believe by default means "no timeout". 

https://docs.python.org/2/library/socket.html#socket.getdefaulttimeout

We should probably set a maximum configurable timeout of 2 minutes or something, and throw an exception if we do timeout.

Comment 1

[William Lachance (:wlach)]

Attachment: timeouts

Comment 2

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder-client

https://github.com/mozilla/treeherder-client/commit/f236a3487eb042638836d4d9c9f79d51cab2a362
Bug 1144138 - Set a timeout for treeherder client requests

Before we would wait forever. Let's start with 120 seconds, we can always
modify in the future.

Comment 3

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder-service

https://github.com/mozilla/treeherder-service/commit/bb2e7c435613f83b7b8cfdbdf89b091da93588ed
Bug 1144138 - Set a timeout for treeherder client requests

Before we would wait forever. Let's start with 120 seconds, we can always
modify in the future.

Comment 4

[William Lachance (:wlach)]

Merged

Comment 6

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/e481e31ffd9add1a0c9190e3fb3340a453fc0e8c
Bug 1144138 - Set a timeout for treeherder client requests

Before we would wait forever. Let's start with 120 seconds, we can always
modify in the future.