Closed Bug 1144149 Opened 9 years ago Closed 2 years ago

[meta] gBrowser's contentDocument and contentWindow properties are not available for remote tabs

Categories

(Firefox :: Tabbed Browser, defect, P5)

x86
All
defect

Tracking

()

RESOLVED FIXED

People

(Reporter: mconley, Unassigned)

References

Details

(Keywords: meta)

A quick DXR shows gBrowser.contentDocument being used in a number of places. The contentDocument property maps to this.mCurrentBrowser.contentDocument, which is undefined in the e10s case.

Same goes for contentWindow.

We should probably add gBrowser.contentDocumentAsCPOW/contentWindowAsCPOW and change all in-tree usage of gBrowser.contentDocument/contentWindow to use gBrowser.contentDocumentAsCPOW/contentWindowAsCPOW instead (much like we did in bug 1051017).

We should then probably mark gBrowser.contentDocument/contentWindow as deprecated.
Flags: firefox-backlog+
I need to file bugs for the places that browser code uses these accessors.
Flags: needinfo?(mconley)
Keywords: meta
Depends on: 1147014
Depends on: 1147017
Depends on: 1147030
Depends on: 1147034
Depends on: 1147035
Depends on: 1147037
Depends on: 1147041
Depends on: 1147043
Depends on: 1147044
Depends on: 1147045
Depends on: 1147046
Depends on: 1147050
Depends on: 1147052
Depends on: 1147056
Depends on: 1147060
Ok, I've filed all of the usages of gBrowser.contentWindow and gBrowser.contentDocument I could find.

All of the test instances will take advantage of shims and should be OK - I've marked those as tracking-e10s:later. For the non-test instances, I've nommed them for triage.

I figure we can use this bug to introduce the gBrowser.contentWindowAsCPOW and gBrowser.contentDocumentAsCPOW shortcuts.
Flags: needinfo?(mconley)
Depends on: 1149262
Priority: -- → P5
Summary: gBrowser's contentDocument and contentWindow properties are not available for remote tabs → [meta] gBrowser's contentDocument and contentWindow properties are not available for remote tabs

CPOWs have been removed.

Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.