Closed Bug 1144214 Opened 5 years ago Closed 5 years ago

Fix DeleteOrphanedBodyAction so that it doesn't orphan cache files if the action is canceled

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla39
Tracking Status
firefox39 --- fixed

People

(Reporter: ehsan, Assigned: ehsan)

References

Details

Attachments

(1 file, 2 obsolete files)

No description provided.
Assignee: nobody → ehsan
Blocks: 1110446
Comment on attachment 8578743 [details] [diff] [review]
Fix DeleteOrphanedBodyAction so that it doesn't orphan cache files if the action is canceled

Review of attachment 8578743 [details] [diff] [review]:
-----------------------------------------------------------------

Just remove the IsCanceled() block.  The Action must not continue after calling Resolve().
Attachment #8578743 - Flags: review?(bkelly) → review-
Attachment #8578743 - Attachment is obsolete: true
Attachment #8578749 - Flags: review?(bkelly)
Comment on attachment 8578749 [details] [diff] [review]
Fix DeleteOrphanedBodyAction so that it doesn't orphan cache files if the action is canceled

Review of attachment 8578749 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM.  Please add a comment, though, indicating we are explicitly ignoring cancel here.
Attachment #8578749 - Flags: review?(bkelly) → review+
Everything we're seeing here is existing known intermittent stuff: https://treeherder.mozilla.org/#/jobs?repo=try&revision=6e511d2c3253
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/61023312923c
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla39
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.