Fix DeleteOrphanedBodyAction so that it doesn't orphan cache files if the action is canceled

RESOLVED FIXED in Firefox 39

Status

()

RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: Ehsan, Assigned: Ehsan)

Tracking

unspecified
mozilla39
Points:
---

Firefox Tracking Flags

(firefox39 fixed)

Details

Attachments

(1 attachment, 2 obsolete attachments)

Comment hidden (empty)
(Assignee)

Comment 1

4 years ago
Created attachment 8578743 [details] [diff] [review]
Fix DeleteOrphanedBodyAction so that it doesn't orphan cache files if the action is canceled
Attachment #8578743 - Flags: review?(bkelly)
(Assignee)

Updated

4 years ago
Assignee: nobody → ehsan
Blocks: 1110446
Comment on attachment 8578743 [details] [diff] [review]
Fix DeleteOrphanedBodyAction so that it doesn't orphan cache files if the action is canceled

Review of attachment 8578743 [details] [diff] [review]:
-----------------------------------------------------------------

Just remove the IsCanceled() block.  The Action must not continue after calling Resolve().
Attachment #8578743 - Flags: review?(bkelly) → review-
(Assignee)

Comment 3

4 years ago
Created attachment 8578749 [details] [diff] [review]
Fix DeleteOrphanedBodyAction so that it doesn't orphan cache files if the action is canceled
(Assignee)

Updated

4 years ago
Attachment #8578743 - Attachment is obsolete: true
(Assignee)

Updated

4 years ago
Attachment #8578749 - Flags: review?(bkelly)
Comment on attachment 8578749 [details] [diff] [review]
Fix DeleteOrphanedBodyAction so that it doesn't orphan cache files if the action is canceled

Review of attachment 8578749 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM.  Please add a comment, though, indicating we are explicitly ignoring cancel here.
Attachment #8578749 - Flags: review?(bkelly) → review+
(Assignee)

Comment 7

4 years ago
Everything we're seeing here is existing known intermittent stuff: https://treeherder.mozilla.org/#/jobs?repo=try&revision=6e511d2c3253
(Assignee)

Comment 8

4 years ago
Created attachment 8579617 [details] [diff] [review]
Fix DeleteOrphanedBodyAction so that it doesn't orphan cache files if the action is canceled
Attachment #8578749 - Attachment is obsolete: true
(Assignee)

Updated

4 years ago
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/61023312923c
Status: NEW → RESOLVED
Last Resolved: 4 years ago
status-firefox39: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla39
You need to log in before you can comment on or make changes to this bug.