1144214 - Fix DeleteOrphanedBodyAction so that it doesn't orphan cache files if the action is canceled

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Comment 1

[(no longer active)]

Attachment: Fix DeleteOrphanedBodyAction so that it doesn't orphan cache files if the action is canceled

Comment 2

[Ben Kelly [:bkelly, not reviewing]]

Comment on attachment 8578743 [details] [diff] [review]
Fix DeleteOrphanedBodyAction so that it doesn't orphan cache files if the action is canceled

Review of attachment 8578743 [details] [diff] [review]:
-----------------------------------------------------------------

Just remove the IsCanceled() block.  The Action must not continue after calling Resolve().

Comment 3

[(no longer active)]

Attachment: Fix DeleteOrphanedBodyAction so that it doesn't orphan cache files if the action is canceled

Comment 4

[Ben Kelly [:bkelly, not reviewing]]

Comment on attachment 8578749 [details] [diff] [review]
Fix DeleteOrphanedBodyAction so that it doesn't orphan cache files if the action is canceled

Review of attachment 8578749 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM.  Please add a comment, though, indicating we are explicitly ignoring cancel here.

Comment 5

[(no longer active)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/96c20db25b6b

Comment 6

[Nigel Babu [:nigelb]]

Backed out:
https://hg.mozilla.org/integration/mozilla-inbound/rev/64ece9e2d0e5
https://hg.mozilla.org/integration/mozilla-inbound/rev/5070a4a97e99

Comment 7

[(no longer active)]

Everything we're seeing here is existing known intermittent stuff: https://treeherder.mozilla.org/#/jobs?repo=try&revision=6e511d2c3253

Comment 8

[(no longer active)]

Attachment: Fix DeleteOrphanedBodyAction so that it doesn't orphan cache files if the action is canceled

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/61023312923c

Comment 10

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/61023312923c