Closed
Bug 1144245
Opened 9 years ago
Closed 9 years ago
Add a LoginTest.jsm module
Categories
(Toolkit :: Password Manager, defect)
Toolkit
Password Manager
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox39 | --- | fixed |
People
(Reporter: Paolo, Assigned: Paolo)
References
Details
Attachments
(1 file, 2 obsolete files)
|
27.20 KB,
patch
|
MattN
:
review+
|
Details | Diff | Splinter Review |
A LoginTest.jsm module would allow us to share code between xpcshell and browser-chrome tests.
|
Assignee | |
Comment 1•9 years ago
|
||
Assignee: nobody → paolo.mozmail
Status: NEW → ASSIGNED
Attachment #8578783 -
Flags: feedback?(MattN+bmo)
|
|
Assignee | |
Updated•9 years ago
|
Iteration: --- → 39.2 - 23 Mar
Points: --- → 1
Flags: qe-verify-
Flags: firefox-backlog+
|
||
Comment 2•9 years ago
|
||
Comment on attachment 8578783 [details] [diff] [review] Work in progress Review of attachment 8578783 [details] [diff] [review]: ----------------------------------------------------------------- ::: toolkit/components/passwordmgr/test/LoginTest.jsm @@ +1,5 @@ > /* Any copyright is dedicated to the Public Domain. > * http://creativecommons.org/publicdomain/zero/1.0/ */ > > +/* > + * Shared functions generally available for testing login components. Two asterisks should be used for JSDoc syntax and so the description gets listed on MXR directory listings. @@ +7,5 @@ > > "use strict"; > > +this.EXPORTED_SYMBOLS = [ > + "LoginTest", I think it's more consistent and clearer to call this LoginTestUtils (along with the filename).
Attachment #8578783 -
Flags: feedback?(MattN+bmo) → feedback+
|
|
Assignee | |
Comment 3•9 years ago
|
||
Attachment #8578783 -
Attachment is obsolete: true
Attachment #8580399 -
Flags: review?(MattN+bmo)
|
|
Assignee | |
Comment 4•9 years ago
|
||
I copied the createTestForm helper inadvertently while rebasing, but I think it can stay in RecipeHelpers for now so we don't have to update the consumers. https://treeherder.mozilla.org/#/jobs?repo=try&revision=898159e4861e
Attachment #8580399 -
Attachment is obsolete: true
Attachment #8580399 -
Flags: review?(MattN+bmo)
Attachment #8580402 -
Flags: review?(MattN+bmo)
|
|
||
Updated•9 years ago
|
Attachment #8580402 -
Flags: review?(MattN+bmo) → review+
|
|
Assignee | |
Comment 5•9 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/a89f634ec7a4
https://hg.mozilla.org/mozilla-central/rev/a89f634ec7a4
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox39:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla39
|
|
||
Updated•9 years ago
|
Blocks: 2015-login-capture-UX
|
|
||
Updated•9 years ago
|
No longer blocks: passwords-2015-UX
You need to log in
before you can comment on or make changes to this bug.
Description
•