margin inside table cell is not correct

RESOLVED FIXED in Future

Status

()

RESOLVED FIXED
17 years ago
14 years ago

People

(Reporter: karnaze, Assigned: bernd_mozilla)

Tracking

({testcase})

Trunk
Future
x86
Windows 2000
testcase
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(4 attachments, 1 obsolete attachment)

(Reporter)

Description

17 years ago
In the test case to follow, the cell block ends up with a negative y origin, but 
I have stepped through the table cell code and it doesn't appear to be setting 
it to that value (in FinishReflowChild).

                            TableCell(td)(1)@0172F2F0 next=02D94764 {30,0,3060,1
410} [state=70040004] [content=02D72C88] [sc=0172F220]<
                              Block(td)(1)@0172F350 {30,-195,3000,1815} [state=0
1c40004] sc=0172F3D0(i=1,b=0)<
(Reporter)

Comment 1

17 years ago
Created attachment 61094 [details]
testcase (3rd attachment from bug 111872)
Target Milestone: --- → mozilla1.1

Comment 2

17 years ago
WFM (BuildID: 2002072204)

Could we close that one now ?

/jc
->Tables
Assignee: attinasi → table
Component: Layout → Layout: Tables
Keywords: testcase
QA Contact: petersen → madhur
Created attachment 130034 [details]
Screenshot of testcase

Bug still occurs in a current CVS trunk build:

TableCell(td)(1)@0x8280f88 next=0x8291f74 {32,0,3264,1504} [state=30040004] ...

  Block(td)(1)@0x828102c {32,-208,3200,1936} [state=00c40014] ...

Add lines to the text area until the scrollbar appears and then the fun begins.

Comment 5

15 years ago
retargeting
Target Milestone: mozilla1.1alpha → Future
Mats, what is the bug here, exactly?  The fact that the lower border of the
<textarea> is not painted?
I'll have to admit I can't remember exactly, my comment above isn't very clear
on what the *rendering problem* was.  It is clear regarding the negative
y-offset though (which is what karnaze reported as a problem in comment 0).
Oh, I see.  So this bug is about the frame model not being what's expected...
gotcha.
(Assignee)

Comment 9

15 years ago
one needs to verify that this does not happen in
http://lxr.mozilla.org/seamonkey/source/layout/html/table/src/nsTableCellFrame.cpp#588
(Assignee)

Comment 10

15 years ago
Created attachment 156734 [details] [diff] [review]
patch for the margin

mozilla up to now centers a overflowing block with respect to the table cell.
With the patch we would not create a negative offset (this makes the initial
rendering compatible to IE and opera)
(Assignee)

Comment 11

15 years ago
taking
Assignee: core.layout.tables → bernd_mozilla
(Assignee)

Updated

15 years ago
Blocks: 245434
(Assignee)

Comment 12

15 years ago
Created attachment 158899 [details]
testcase with different valign
(Assignee)

Comment 13

15 years ago
Created attachment 158901 [details] [diff] [review]
clip ytop
Attachment #156734 - Attachment is obsolete: true
(Assignee)

Updated

15 years ago
Attachment #158901 - Flags: superreview?(bzbarsky)
Attachment #158901 - Flags: review?(bzbarsky)
Comment on attachment 158901 [details] [diff] [review]
clip ytop

r+sr=bzbarsky
Attachment #158901 - Flags: superreview?(bzbarsky)
Attachment #158901 - Flags: superreview+
Attachment #158901 - Flags: review?(bzbarsky)
Attachment #158901 - Flags: review+
(Assignee)

Comment 15

14 years ago
fix checked in
Status: NEW → RESOLVED
Last Resolved: 14 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.