1144337 - Add tests to ensure that cacheName is only honored on CacheStorage, and not Cache

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Comment 1

[(no longer active)]

Attachment: Add tests to ensure that cacheName is only honored on CacheStorage, and not Cache

Comment 2

[Ben Kelly [:bkelly, not reviewing]]

Comment on attachment 8578878 [details] [diff] [review]
Add tests to ensure that cacheName is only honored on CacheStorage, and not Cache

Review of attachment 8578878 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with the caches.match() fix.

::: dom/cache/test/mochitest/test_cache_matchAll_request.js
@@ +121,5 @@
>        checkResponse(r[0], response1, response1Text),
>        checkResponse(r[1], response3, response3Text)
>      ]);
>    }).then(function() {
> +    return caches.match(undefined, {cacheName: name + "mambojambo"})

The first arg to caches.match() is not optional.  This should fail regardless of the cacheName option.  Please replace undefined with the known request.

Comment 3

[(no longer active)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/c89f330bf781

Comment 4

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/c89f330bf781