Add tests to ensure that cacheName is only honored on CacheStorage, and not Cache

RESOLVED FIXED in Firefox 39

Status

()

RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: Ehsan, Assigned: Ehsan)

Tracking

unspecified
mozilla39
Points:
---

Firefox Tracking Flags

(firefox39 fixed)

Details

Attachments

(1 attachment)

Comment hidden (empty)
(Assignee)

Comment 1

4 years ago
Created attachment 8578878 [details] [diff] [review]
Add tests to ensure that cacheName is only honored on CacheStorage, and not Cache
Attachment #8578878 - Flags: review?(bkelly)
(Assignee)

Updated

4 years ago
Assignee: nobody → ehsan
Blocks: 1110493
Comment on attachment 8578878 [details] [diff] [review]
Add tests to ensure that cacheName is only honored on CacheStorage, and not Cache

Review of attachment 8578878 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with the caches.match() fix.

::: dom/cache/test/mochitest/test_cache_matchAll_request.js
@@ +121,5 @@
>        checkResponse(r[0], response1, response1Text),
>        checkResponse(r[1], response3, response3Text)
>      ]);
>    }).then(function() {
> +    return caches.match(undefined, {cacheName: name + "mambojambo"})

The first arg to caches.match() is not optional.  This should fail regardless of the cacheName option.  Please replace undefined with the known request.
Attachment #8578878 - Flags: review?(bkelly) → review+
https://hg.mozilla.org/mozilla-central/rev/c89f330bf781
Status: NEW → RESOLVED
Last Resolved: 4 years ago
status-firefox39: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla39
You need to log in before you can comment on or make changes to this bug.