Closed Bug 1144337 Opened 5 years ago Closed 5 years ago

Add tests to ensure that cacheName is only honored on CacheStorage, and not Cache

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla39
Tracking Status
firefox39 --- fixed

People

(Reporter: ehsan, Assigned: ehsan)

References

Details

Attachments

(1 file)

No description provided.
Assignee: nobody → ehsan
Blocks: cachetests
Comment on attachment 8578878 [details] [diff] [review]
Add tests to ensure that cacheName is only honored on CacheStorage, and not Cache

Review of attachment 8578878 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with the caches.match() fix.

::: dom/cache/test/mochitest/test_cache_matchAll_request.js
@@ +121,5 @@
>        checkResponse(r[0], response1, response1Text),
>        checkResponse(r[1], response3, response3Text)
>      ]);
>    }).then(function() {
> +    return caches.match(undefined, {cacheName: name + "mambojambo"})

The first arg to caches.match() is not optional.  This should fail regardless of the cacheName option.  Please replace undefined with the known request.
Attachment #8578878 - Flags: review?(bkelly) → review+
https://hg.mozilla.org/mozilla-central/rev/c89f330bf781
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla39
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.