1144340 - [meta] SpiderMonkey should store 1-based column numbers internally

Status: NEW

(Core :: JavaScript Engine, defect)

Description

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

SpiderMonkey (and all other browsers) use 1-based column numbers in error.stack, but we store it as 0-based internally.

Changing the way we store it is fairly easy, but tests are really annoying to update. Especially since there are third party shared tests.

This patch changed the storage, but not all the tests: https://bugzilla.mozilla.org/attachment.cgi?id=8578427

Could probably use it as a starting point for actually fixing this bug.

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1144340: bindings: Provide better info for value-returning maplike methods.

For now, this is only the |get| method.

Unfortunately this doesn't change the generated JitInfo, since the return type
needs to be nullable to take into account the missing key case.

Still worth it, I guess, since it improves the generated code a bit.

Review commit: https://reviewboard.mozilla.org/r/64772/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/64772/

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Wrong bug no, sorry.