Open Bug 1144340 Opened 6 years ago Updated 8 months ago

SpiderMonkey should store 1-based column numbers internally

Categories

(Core :: JavaScript Engine, defect)

x86
macOS
defect
Not set
normal

Tracking

()

People

(Reporter: fitzgen, Unassigned)

References

(Blocks 1 open bug)

Details

Attachments

(1 obsolete file)

SpiderMonkey (and all other browsers) use 1-based column numbers in error.stack, but we store it as 0-based internally.

Changing the way we store it is fairly easy, but tests are really annoying to update. Especially since there are third party shared tests.

This patch changed the storage, but not all the tests: https://bugzilla.mozilla.org/attachment.cgi?id=8578427

Could probably use it as a starting point for actually fixing this bug.
Attachment #8771733 - Attachment is obsolete: true
Attachment #8771733 - Flags: review?(bzbarsky)
QA Contact: ealvarez
Blocks: 1620583
You need to log in before you can comment on or make changes to this bug.