Status

Add-on SDK
General
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: mossop, Assigned: mossop)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

46 bytes, text/x-github-pull-request
erikvold
: review+
Details | Review | Splinter Review
Comment hidden (empty)
(Assignee)

Comment 1

3 years ago
Created attachment 8578989 [details] [review]
pull request
Attachment #8578989 - Flags: review?(evold)
Comment on attachment 8578989 [details] [review]
pull request

If you think we can make a test for this then please include it if you have time for make a bug for it please.
Attachment #8578989 - Flags: review?(evold) → review+
(In reply to Erik Vold [:erikvold] (please needinfo? me) from comment #2)
> Comment on attachment 8578989 [details] [review]
> pull request
> 
> If you think we can make a test for this then please include it if you have
> time for make a bug for it please.

*or make a bug

Comment 4

3 years ago
Commits pushed to master at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/59e203705d1846e82112af706b4b9f6697513fa4
Bug 1144403: Fix sdk/places/events leaks by unregistering observers on unload.

https://github.com/mozilla/addon-sdk/commit/2710700094c3593b595631c7c4996d8a02b7fd1f
Merge pull request #1903 from Mossop/bug1144403

Bug 1144403: Fix sdk/places/events leaks by unregistering observers on unload. r=erikvold
(Assignee)

Comment 5

3 years ago
Knee deep in leak fixes right now and since this is detectable by leak tools I think we can just make do with the follow-up bug 1144735.
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
(Assignee)

Updated

3 years ago
Blocks: 1140002
You need to log in before you can comment on or make changes to this bug.