1144424 - Rename "{self,total} allocations" to "{self,total} allocations sampled"

Status: RESOLVED FIXED

(DevTools :: Performance Tools (Profiler/Timeline), defect)

Description

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

The allocation numbers are sampled and not exact. The existing labels imply that they are exact, when they aren't, and we should change them so they don't imply that.

Comment 1

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Attachment: Rename '{self,total} allocations' to '{self,total} sampled allocations' in the performance tool

Comment 2

[Jordan Santell [:jsantell] [@jsantell]]

Comment on attachment 8579014 [details] [diff] [review]
Rename '{self,total} allocations' to '{self,total} sampled allocations' in the performance tool

Review of attachment 8579014 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/locales/en-US/chrome/browser/devtools/profiler.dtd
@@ +59,5 @@
>  <!ENTITY profilerUI.table.function        "Function">
> +<!ENTITY profilerUI.table.totalAlloc1       "Total Sampled Allocations">
> +<!ENTITY profilerUI.table.totalAllocTooltip "The total number of Object allocations sampled here and in callees.">
> +<!ENTITY profilerUI.table.selfAlloc1        "Self Sampled Allocations">
> +<!ENTITY profilerUI.table.selfAllocTooltip  "The number of Object allocations sampled here.">

s/here/at this location/

Comment 3

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Attachment: Rename '{self,total} allocations' to '{self,total} sampled allocations' in the performance tool

Comment 4

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

(No try push because this is just a re-labeling)

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/fx-team/rev/2422c303f64f

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/2422c303f64f