1144426 - [Settings][Call Barring] Entering the wrong passcode in Call Barring results in ambiguous error message.

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[Martin Shuman [:Marty]]

Attachment: logcat-call-barring-error.txt

Description:
If the user enters an incorrect passcode when activating Call Barring, the user will be presented with the following, ambiguous error message:

"Error while updating the item: GenericFailure"

Repro Steps:
1) Update a Flame to 20150317073344
2) Open the Settings app and navigate to Call Settings > Call Barring
3) Attempt to activate Incoming Calls All with the wrong passcode

Actual:
The error message is ambiguous, and does not indicate the problem accurately to the user.

Expected:
The error message is clear and accurately indicates the problem to the user.

Environmental Variables:
Device: Flame 3.0 (319MB)(Full Flash)
Build ID: 20150317073344
Gaia: 738987bd80b0ddb4ccf853855388c2627e19dcc1
Gecko: 008b3f65a7e0
Gonk: b83fc73de7b64594cd74b33e498bf08332b5d87b
Version: 39.0a1 (3.0)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:39.0) Gecko/39.0 Firefox/39.0

Repro frequency: 5/5
See attached: screenshot, logcat

Comment 1

[Martin Shuman [:Marty]]

Attachment: Call-Barring-Error-Screenshot.png

Comment 2

[Martin Shuman [:Marty]]

This issue DOES occur on Flame 2.2 builds.
The error message is ambiguous, and does not indicate the problem accurately to the user.

Environmental Variables:
Device: Flame 2.2 (319MB)(Full Flash)
Build ID: 20150316002502
Gaia: a6b2d3f8478ec250beb49950fecbb8a16465ff6f
Gecko: 18619f8f6c5c
Gonk: b83fc73de7b64594cd74b33e498bf08332b5d87b
Version: 37.0 (2.2)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0

This issue does NOT occur on Flame 2.1 builds.
The Call Barring feature is not implemented in this branch.

Comment 3

[Peter Bylenga [:PBylenga]]

NI on component owner for nomination decision and assignment.

Comment 4

[Gerry Chang [:gchang]]

I can't recreate the issue. When I tap change passcode in Call Barring, no matter what I input in current passcode, I always be redirected to "New passcode" page.

Build information:
Gaia-Rev        a6b2d3f8478ec250beb49950fecbb8a16465ff6f
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/18619f8f6c5c
Build-ID        20150316002502
Version         37.0
Device-Name     flame
FW-Release      4.4.2

Comment 5

[Johan Lorenzo [:jlorenzo]]

NI myself to check if I can repro with an Orange SIM.

Comment 6

[Martin Shuman [:Marty]]

Gerry, this error message is seen when trying to turn on or activate call barring with the wrong passcode, not when trying to change the passcode.  I've added a video link to clarify the STR.

Additionally, I've written bug 1145299 for the issue you encountered.

Comment 7

[Johan Lorenzo [:jlorenzo]]

I got the same issue as what's described in comment 6. Do you reproduce it, Gerry?

Comment 8

[Gerry Chang [:gchang]]

Yes, NI developer for investigation.
Hi Arthur,
Can you help on this?

Comment 9

[Arthur Chen [:arthurcc][inactive after 6/30]]

Fernando, could you help check if this is expected? Thanks.

Comment 10

[Fernando Campo (:fcampo)]

It is the expected answer as we just show the error received from the request.
If we want to show some more specific error, that should come from the API.

In this case, GenericFailure is the error.name returned from the call.
https://github.com/mozilla-b2g/gaia/blob/master/apps/settings/js/panels/call_barring/panel.js#L106-L112

Comment 11

[Arthur Chen [:arthurcc][inactive after 6/30]]

Hsinyi, is it expected to get a generic error when calling to `setCallBarringOption` under this condition?

Comment 12

[Hsin-Yi Tsai (she/her) [:hsinyi]]

(In reply to Arthur Chen [:arthurcc] from comment #11)
> Hsinyi, is it expected to get a generic error when calling to
> `setCallBarringOption` under this condition?

The error message was coming from vendor rild/modem. What gecko did was just delivering it to Gaia.
In this case, gecko also had no more information than gaia. Gecko has no way to provide more specific messages.

Comment 13

[Arthur Chen [:arthurcc][inactive after 6/30]]

Thanks for the clarification, Hsinyi. Close the bug as wontfix first.

Comment 14

[[e-mail]]

`GenericFailure` is techniquily right but means nothing to user.

Refer to
http://androidforums.com/threads/call-barring-password.42656/

"Network or SIM card error" might be the better wording.

If the new term looks good I'll set this as a backlog and manage to change it.

Comment 15

[Tina Hsieh[:Tina_Hsieh] UX]

Referring to what Hsinyi confirmed in offline discussion, there are two use cases which may cause this error:
1. Wrong passcode
2. Carrier doesn't support this service. Users need to ask their carrier to enable this service.

Therefore I suggest that we can give a prompt as "Network or passcode error"
Also ni Matej if he can give us a suggestion.

Comment 16

[Matej Novak [:matej]]

(In reply to Tina Hsieh[:Tina_Hsieh] UX from comment #15)
> Referring to what Hsinyi confirmed in offline discussion, there are two use
> cases which may cause this error:
> 1. Wrong passcode
> 2. Carrier doesn't support this service. Users need to ask their carrier to
> enable this service.
> 
> Therefore I suggest that we can give a prompt as "Network or passcode error"
> Also ni Matej if he can give us a suggestion.

Are you we using "passcode" elsewhere? I would recommend "password" instead.

Comment 17

[Tina Hsieh[:Tina_Hsieh] UX]

(In reply to Matej Novak [:matej] from comment #16)
> (In reply to Tina Hsieh[:Tina_Hsieh] UX from comment #15)
> > Referring to what Hsinyi confirmed in offline discussion, there are two use
> > cases which may cause this error:
> > 1. Wrong passcode
> > 2. Carrier doesn't support this service. Users need to ask their carrier to
> > enable this service.
> > 
> > Therefore I suggest that we can give a prompt as "Network or passcode error"
> > Also ni Matej if he can give us a suggestion.
> 
> Are you we using "passcode" elsewhere? I would recommend "password" instead.


Currently we use ”passcode" for screen lock, "password" for Wi-Fi setting. Both of the strings are used in Firefox OS. Will “password" still be better than "passcode"?

Comment 18

[Matej Novak [:matej]]

(In reply to Tina Hsieh[:Tina_Hsieh] UX from comment #17)
> (In reply to Matej Novak [:matej] from comment #16)
> > (In reply to Tina Hsieh[:Tina_Hsieh] UX from comment #15)
> > > Referring to what Hsinyi confirmed in offline discussion, there are two use
> > > cases which may cause this error:
> > > 1. Wrong passcode
> > > 2. Carrier doesn't support this service. Users need to ask their carrier to
> > > enable this service.
> > > 
> > > Therefore I suggest that we can give a prompt as "Network or passcode error"
> > > Also ni Matej if he can give us a suggestion.
> > 
> > Are you we using "passcode" elsewhere? I would recommend "password" instead.
> 
> 
> Currently we use ”passcode" for screen lock, "password" for Wi-Fi setting.
> Both of the strings are used in Firefox OS. Will “password" still be better
> than "passcode"?

If you use both, I'll let you choose what you think works better here. Thanks.

Comment 19

[Tina Hsieh[:Tina_Hsieh] UX]

Thanks, Matej :)

Let's use "passcode" because strings in call baring setting are "passcode". Moreover, there is a description on passcode input UI demonstrating that the "passcode" is provided by the carrier instead of users.

Comment 20

[GitHub Autolander Bot]

Attachment: [gaia] gasolin:master > mozilla-b2g:master

Comment 21

[GitHub Autolander Bot]

Attachment: [gaia] gasolin:issue-1144426 > mozilla-b2g:master

Comment 22

[[e-mail]]

Comment on attachment 8681745 [details] [review]
[gaia] gasolin:issue-1144426 > mozilla-b2g:master

checked with Tina that we'd like to add special case to handle the genericFailure message.

Also add tests

Comment 23

[Yura Zenevich [:yzen] (please use "needinfo")]

Comment on attachment 8681745 [details] [review]
[gaia] gasolin:issue-1144426 > mozilla-b2g:master

Looks good with just 1 comment.

Comment 24

[[e-mail]]

to avoid any string change side-effect, file bug 1220532 (as good first bug) to handle the nit

Comment 25

[[e-mail]]

merged https://github.com/mozilla-b2g/gaia/commit/b4e74d553f496721f12e957476b2b68754c0842d

thanks!

Comment 26

[Autumn.Qiu(Leave from Mozilla)]

This bug has been verified as "pass" on the latest build of Aries KK v2.6 and Flame KK v2.6 512mb by the STR in comment 0.

Actual results: The error message shows that “Network or passcode error”, it is clear and accurately indicates the problem to the user.

See attachment: Verified_Aries_KK_v2.6_err.png
Reproduce rate: 0/10

Device: Aries KK 2.6 (master)(Pass)
Build ID               20151104004249
Gaia Revision          61918ddd9ccce104c009e873e34a0791e125753a
Gaia Date              2015-11-03 17:22:30
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/f742b9412ed5aace90ad863b276faae0641090a8
Gecko Version          45.0a1
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20151104.000116
Firmware Date          Wed Nov  4 00:01:24 UTC 2015
Bootloader             s1


Device: Flame KK 2.6 512mb (master)(Pass)
Build ID               20151103150203
Gaia Revision          61918ddd9ccce104c009e873e34a0791e125753a
Gaia Date              2015-11-03 17:22:30
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/f742b9412ed5aace90ad863b276faae0641090a8
Gecko Version          45.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20151103.182550
Firmware Date          Tue Nov  3 18:26:03 EST 2015
Firmware Version       v18D v4
Bootloader             L1TC000118D0

Comment 27

[Autumn.Qiu(Leave from Mozilla)]

Attachment: Verified_Aries_KK_v2.6_err.png