1144435 - Defined defaultLanguage in meta not used as default locale

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::L10n, defect)

Description

[fr.alexisthomas]

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Firefox/38.0
Build ID: 20150316004007

Steps to reproduce:

Set meta in application index.html:
<meta name="defaultLanguage" content="en">


Actual results:

Error logged at runtime about no en-US resource found


Expected results:

No error and use my locale file named app.en.properties

Comment 1

[GitHub Autolander Bot]

Attachment: [gaia] ath0mas:fix-l10n-default-locale > mozilla-b2g:master

Comment 2

[Staś Małolepszy :stas]

Comment on attachment 8579017 [details] [review]
[gaia] ath0mas:fix-l10n-default-locale > mozilla-b2g:master

Ha, good catch, thanks for the pull request.  It's a bit unfortunate that we're using both 'locale' and 'language' through l10n.js. r=me.

Comment 3

[Staś Małolepszy :stas]

Autolander do your thing.

Comment 4

[GitHub Autolander Bot]

Pull request has landed in master: https://github.com/mozilla-b2g/gaia/commit/c9a24a43b94f23f00f9065e8d63081fe1e7289c8

Comment 5

[Staś Małolepszy :stas]

L20n.js: https://github.com/l20n/l20n.js/commit/19d6253512196fe33d504827f6d52099cc29007f

Comment 6

[Ryan VanderMeulen [:RyanVM]]

Reverted for Gaia unit test failures.
Master: https://github.com/mozilla-b2g/gaia/commit/d95dc4966fd301a4f91c5d610646ec406b80a341

https://treeherder.mozilla.org/logviewer.html#?job_id=1538388&repo=b2g-inbound

Comment 7

[Staś Małolepszy :stas]

Hmm, I though autolander should have refused to land if there were test failures?  Sorry for the trouble.

Alex, can you fix the failing tests seen in https://treeherder.mozilla.org/logviewer.html#?job_id=1538388&repo=b2g-inbound and resumit a pull request, please?

Comment 8

[GitHub Autolander Bot]

Attachment: [gaia] ath0mas:fix-l10n-default-locale > mozilla-b2g:master

Comment 9

[Staś Małolepszy :stas]

Comment on attachment 8579680 [details] [review]
[gaia] ath0mas:fix-l10n-default-locale > mozilla-b2g:master

r=me, thanks!

Comment 10

[Staś Małolepszy :stas]

Let's wait for Gaia to reopen before we land this again.

Comment 11

[GitHub Autolander Bot]

Pull request has landed in master: https://github.com/mozilla-b2g/gaia/commit/abbd5e592d894ea7050c575c98bd14b77f4eba44

Comment 12

[fr.alexisthomas]

Seems that this merge has been done, but changes are not on master branch and commit is not in master history neither.

Comment 13

[Staś Małolepszy :stas]

(In reply to fr.alexisthomas from comment #12)
> Seems that this merge has been done, but changes are not on master branch
> and commit is not in master history neither.

Ryan, any idea what happened here?  Thanks!

Comment 14

[Ryan VanderMeulen [:RyanVM]]

No clue, sounds like a question for our Autoland maintainer ;)

Comment 15

[Kevin Grandon :kgrandon]

Hmm, my likely guess here is that is missing a tree closure check, and this tried to land during the roller coaster of closures yesterday. For now let's land manually and I'll dig in and investigate what we do during a tree closure. Thanks!

https://github.com/mozilla-b2g/gaia/commit/66558ce7f36809a20d1c721fd4d457913b09c5c7

Comment 16

[Staś Małolepszy :stas]

Thanks, Kevin, for landing this for us!

Comment 17

[fr.alexisthomas]

Thanks all ;)