Defined defaultLanguage in meta not used as default locale

RESOLVED FIXED

Status

Firefox OS
Gaia::L10n
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: fr.alexisthomas, Assigned: fr.alexisthomas)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Assignee)

Description

3 years ago
User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Firefox/38.0
Build ID: 20150316004007

Steps to reproduce:

Set meta in application index.html:
<meta name="defaultLanguage" content="en">


Actual results:

Error logged at runtime about no en-US resource found


Expected results:

No error and use my locale file named app.en.properties
Created attachment 8579017 [details] [review]
[gaia] ath0mas:fix-l10n-default-locale > mozilla-b2g:master
Comment on attachment 8579017 [details] [review]
[gaia] ath0mas:fix-l10n-default-locale > mozilla-b2g:master

Ha, good catch, thanks for the pull request.  It's a bit unfortunate that we're using both 'locale' and 'language' through l10n.js. r=me.
Attachment #8579017 - Flags: review+
Autolander do your thing.
Status: UNCONFIRMED → NEW
Ever confirmed: true
Keywords: checkin-needed

Updated

3 years ago
Keywords: checkin-needed

Updated

3 years ago
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Reverted for Gaia unit test failures.
Master: https://github.com/mozilla-b2g/gaia/commit/d95dc4966fd301a4f91c5d610646ec406b80a341

https://treeherder.mozilla.org/logviewer.html#?job_id=1538388&repo=b2g-inbound
Assignee: nobody → fr.alexisthomas
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Hmm, I though autolander should have refused to land if there were test failures?  Sorry for the trouble.

Alex, can you fix the failing tests seen in https://treeherder.mozilla.org/logviewer.html#?job_id=1538388&repo=b2g-inbound and resumit a pull request, please?
Flags: needinfo?(fr.alexisthomas)
Created attachment 8579680 [details] [review]
[gaia] ath0mas:fix-l10n-default-locale > mozilla-b2g:master
Comment on attachment 8579680 [details] [review]
[gaia] ath0mas:fix-l10n-default-locale > mozilla-b2g:master

r=me, thanks!
Attachment #8579680 - Flags: review+
Let's wait for Gaia to reopen before we land this again.
Flags: needinfo?(fr.alexisthomas)
Keywords: checkin-needed

Updated

3 years ago
Keywords: checkin-needed

Updated

3 years ago
Status: REOPENED → RESOLVED
Last Resolved: 3 years ago3 years ago
Resolution: --- → FIXED
(Assignee)

Comment 12

3 years ago
Seems that this merge has been done, but changes are not on master branch and commit is not in master history neither.
(In reply to fr.alexisthomas from comment #12)
> Seems that this merge has been done, but changes are not on master branch
> and commit is not in master history neither.

Ryan, any idea what happened here?  Thanks!
Status: RESOLVED → REOPENED
Flags: needinfo?(ryanvm)
Resolution: FIXED → ---
No clue, sounds like a question for our Autoland maintainer ;)
Flags: needinfo?(ryanvm) → needinfo?(kgrandon)
Hmm, my likely guess here is that is missing a tree closure check, and this tried to land during the roller coaster of closures yesterday. For now let's land manually and I'll dig in and investigate what we do during a tree closure. Thanks!

https://github.com/mozilla-b2g/gaia/commit/66558ce7f36809a20d1c721fd4d457913b09c5c7
Status: REOPENED → RESOLVED
Last Resolved: 3 years ago3 years ago
Flags: needinfo?(kgrandon)
Resolution: --- → FIXED
Thanks, Kevin, for landing this for us!
(Assignee)

Comment 17

3 years ago
Thanks all ;)
You need to log in before you can comment on or make changes to this bug.