1144438 - Handle when profiler unexpectedly stops (via "profiler-stopped" from root)

Status: RESOLVED FIXED

(DevTools :: Performance Tools (Profiler/Timeline), defect, P3)

Comment 1

[Victor Porof [:vporof][:vp]]

Not specifically blocking v2.

Comment 2

[Victor Porof [:vporof][:vp]]

Triaging. Filter on ADRENOCORTICOTROPIC (yes).

Comment 3

[Greg Tatum [:gregtatum]]

Attachment: Bug 1144438 - Remove false error notification when the profiler stops; r?julienw

If the profiler unexpectedly stops, this is fine, as the new recording infrastructure
is most likely in control of it. This was leading to lots of spurious errors when
working on the new about:profiling infrastructure.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bc5727185383
Remove false error notification when the profiler stops; r=julienw

Comment 5

[Arthur Iakab [arthur_iakab]]

Backed out 6 changesets (bug 1144438, bug 1617208, bug 1597378) for causing mochitest failures on test_perf-settings-entries.html.

Backout revision Backed out 6 changesets (bug 1144438, bug 1617208, bug 1597378) for causing mochitest failures on test_perf-settings-entries.html.

Failed push https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&revision=2181d8a99229269677715ef8b20b7d3860667004&searchStr=os%2Cx%2C10.14%2Cdebug%2Cmochitests%2Cwithout%2Ce10s%2Ctest-macosx1014-64%2Fdebug-mochitest-chrome-1proc-1%2Cm-1proc%28c1%29

Failures https://treeherder.mozilla.org/#/jobs?repo=autoland&selectedJob=290405620&fromchange=2181d8a99229269677715ef8b20b7d3860667004&searchStr=os%2Cx%2C10.14%2Cdebug%2Cmochitests%2Cwithout%2Ce10s%2Ctest-macosx1014-64%2Fdebug-mochitest-chrome-1proc-1%2Cm-1proc%28c1%29

Failure log https://treeherder.mozilla.org/logviewer.html#?job_id=290411296&repo=autoland

Greg can you please take a look?

Comment 6

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b1f2658377e0
Backed out 6 changesets (bug 1144438, bug 1617208, bug 1597378) for causing mochitest failures on  test_perf-settings-entries.html.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4e152220ad14
Remove false error notification when the profiler stops; r=julienw

Comment 8

[Arthur Iakab [arthur_iakab]]

Backed out 6 changesets (bug 1144438, bug 1617208, bug 1597378) for causing devtools failures on browser_all_files_referenced.js

Backout revision https://hg.mozilla.org/integration/autoland/rev/1c55bc6e995ada5e4b6a61f0ab0ce325a5988692

Failures https://treeherder.mozilla.org/#/jobs?repo=autoland&searchStr=linux%2C18.04%2Cx64%2Cshippable%2Copt%2Cmochitests%2Ctest-linux1804-64-shippable%2Fopt-mochitest-devtools-chrome-e10s-1%2Cm%28dt1%29&fromchange=73d1a5e103376d0baba223a48ef1e1977d408043

Failed push https://treeherder.mozilla.org/#/jobs?repo=autoland&searchStr=linux%2C18.04%2Cx64%2Cshippable%2Copt%2Cmochitests%2Ctest-linux1804-64-shippable%2Fopt-mochitest-devtools-chrome-e10s-1%2Cm%28dt1%29&revision=eef173a3678d6b219ba25f583434621c7b883463

Failure log https://treeherder.mozilla.org/logviewer.html#?job_id=290471398&repo=autoland

Greg can you please take a look?

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/39c6564c2a6e
Remove false error notification when the profiler stops; r=julienw

Comment 10

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/39c6564c2a6e