Closed
Bug 1144494
Opened 10 years ago
Closed 10 years ago
Toggle "network.debugging.enabled" from developer menu
Categories
(Firefox OS Graveyard :: Gaia::Settings, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: jessica, Assigned: jessica)
References
Details
Attachments
(1 file)
I'd like to provide an easy way to toggle network debugging log from developer menu.
In bug 1139736, we bind settings key "network.debugging.enabled" to preference. Therefore, we could simply add a menu option to toggle the settings and the logs in NetworkManager, NetworkService and TetheringService will be enabled/disabled accordingly.
This is useful for debugging data connection as wells as wifi.
Comment 1•10 years ago
|
||
Assignee | ||
Comment 2•10 years ago
|
||
Comment on attachment 8579173 [details] [review]
[gaia] jessi3py:bugzilla/1144494 > mozilla-b2g:master
Hi Arthur, may I have your review on this? Thanks.
Attachment #8579173 -
Flags: review?(arthur.chen)
Comment 3•10 years ago
|
||
Comment on attachment 8579173 [details] [review]
[gaia] jessi3py:bugzilla/1144494 > mozilla-b2g:master
Thanks for working on this. The patch is looking good to me. However, when creating a new setting field we should also specify the default value in build/config/common-settings.json. Please set the default value of 'network.debugging.enabled' and 'ril.debugging.enabled' (I forgot this last time, :p) to false.
Attachment #8579173 -
Flags: review?(arthur.chen)
Assignee | ||
Comment 4•10 years ago
|
||
(In reply to Arthur Chen [:arthurcc] from comment #3)
> Comment on attachment 8579173 [details] [review]
> [gaia] jessi3py:bugzilla/1144494 > mozilla-b2g:master
>
> Thanks for working on this. The patch is looking good to me. However, when
> creating a new setting field we should also specify the default value in
> build/config/common-settings.json. Please set the default value of
> 'network.debugging.enabled' and 'ril.debugging.enabled' (I forgot this last
> time, :p) to false.
Thanks Arthur for the remind. I've updated the patch in github. Could you review it again?
Assignee | ||
Updated•10 years ago
|
Attachment #8579173 -
Flags: review?(arthur.chen)
Comment 5•10 years ago
|
||
Comment on attachment 8579173 [details] [review]
[gaia] jessi3py:bugzilla/1144494 > mozilla-b2g:master
r=me, thanks!
Please add a checkin-needed keyword so that auto lander will merge the patch for you. However, gaia tree is closed now, let me know if the patch is not merged automatically.
Attachment #8579173 -
Flags: review?(arthur.chen) → review+
Comment 6•10 years ago
|
||
master: 6d27d00da5c30ac52bc94b2e14eed5e4bb4ead37
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 7•10 years ago
|
||
Thanks, Arthur. :)
You need to log in
before you can comment on or make changes to this bug.
Description
•