Closed Bug 1144507 Opened 6 years ago Closed 6 years ago

incorrect Promise usage in test_font_loading_api.html

Categories

(Core :: CSS Parsing and Computation, defect)

Product:
Core
Component:
CSS Parsing and Computation
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla39
Tracking Flags:
Tracking Status
firefox37 --- fixed
firefox38 --- fixed
firefox39 --- fixed

People

(Reporter: heycam, Assigned: heycam)

References

Details

Attachments

(1 file)

patch
4.94 KB, patch
jtd
: review+
Details | Diff | Splinter Review 
There are a few places in test_font_loading_api.html where we call some_promise.then(another_promise) instead of some_promise.then(() => another_promise), and end up not waiting for another_promise to resolve.  This might be contributing to the random test failures in here.
Attached patch patch — — Splinter Review
Assignee: nobody → cam
Status: NEW → ASSIGNED
Attachment #8579109 - Flags: review?(jdaggett)
Attachment #8579109 - Flags: review?(jdaggett) → review+
Blocks: 1079614
https://hg.mozilla.org/mozilla-central/rev/800d5d8f921f
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox39: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla39
You need to log in before you can comment on or make changes to this bug.