1144535 - Increase stack size in the Nuwa process

Status: RESOLVED FIXED

(Core :: IPC, defect)

Description

[Cervantes Yu [:cyu] [:cervantes]]

This is a followup to bug 1119157 comment #14 to increase the stack size of the threads cloned by Nuwa.

Comment 1

[Cervantes Yu [:cyu] [:cervantes]]

Attachment: Increase thread stack size in the Nuwa process

We allocate thread stacks using mmap() in the Nuwa process(). Increase the stack size to default (= 1MiB) should have no effect on memory usage.

Comment 2

[Cervantes Yu [:cyu] [:cervantes]]

Try push log: https://treeherder.mozilla.org/#/jobs?repo=try&revision=e917e7d3fec3

Comment 3

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Is there not some way to do it based on the stack size that was actually requested when the thread was created? Hard-coding any size seems like it will bite us somewhere eventually.

Comment 4

[Andrew Sutherland [:asuth] (he/him)]

Comment on attachment 8579256 [details] [diff] [review]
Increase thread stack size in the Nuwa process

I agree with Ben.  The requested stack size (which defaults to 1 megabyte in at least some versions of bionic) is in the 'attr' attribute to pthread_create.  We should just use that.

Comment 5

[Andrew Sutherland [:asuth] (he/him)]

(Using pthread_attr_getstacksize/pthread_attr_getstackaddr/pthread_attr_getstack.  We may also want to care about pthread_attr_getguardsize too.)

Comment 6

[Cervantes Yu [:cyu] [:cervantes]]

Attachment: Respect caller-specified thread attributes.

Changes:
* Respect the attributes (detachstate, stacksize, guardsize) when creating the threads in the Nuwa process.
* If the caller doesn't specify pthread_attr_t, use the default 1MB stack size as Android does.

Try push log: https://treeherder.mozilla.org/#/jobs?repo=try&revision=12f23ec99289

* We might still need to copy other pthread_attr_t attributes. Or maybe it's better if we don't copy the thread attributes one by one, but just modify the one as necessary (pthread_attr_setstack()).

Comment 7

[Andrew Sutherland [:asuth] (he/him)]

Comment on attachment 8580649 [details] [diff] [review]
Respect caller-specified thread attributes.

Yes, I think it would be an improvement to propagate the other pthread_attr_t attributes some way.  And/or causing the thread creation to fail if the attributes aren't expected, like starting a thread in the detached state might be a concerning thing to happen in the pre-fork NuWa process.  But that seems like it wants to be a separate bug.

Comment 8

[Cervantes Yu [:cyu] [:cervantes]]

https://hg.mozilla.org/integration/b2g-inbound/rev/d8c2f3038fbd

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/d8c2f3038fbd