Closed
Bug 1144538
Opened 10 years ago
Closed 10 years ago
[Settings] refactor TaskScheduler and CallConstant
Categories
(Firefox OS Graveyard :: Gaia::Settings, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: eragonj, Assigned: eragonj)
References
Details
Attachments
(1 file)
With this patch, TaskScheduler and CallConstants are all extracted out to make Call.js more isolated.
|
||
Comment 1•10 years ago
|
||
|
Assignee | |
Comment 2•10 years ago
|
||
Comment on attachment 8579170 [details] [review]
[gaia] EragonJ:bug-1144538 > mozilla-b2g:master
Arthur, this is the first step to refactor Call.js, in this patch, I tried to extract the CallConstant & TaskScheduler out to make call.js lighter.
Please help me check this patch when you have time, thanks ;)
Attachment #8579170 -
Flags: review?(arthur.chen)
|
||
Comment 3•10 years ago
|
||
Comment on attachment 8579170 [details] [review]
[gaia] EragonJ:bug-1144538 > mozilla-b2g:master
Awesome! r=me with only one nit addressed, thanks.
Attachment #8579170 -
Flags: review?(arthur.chen) → review+
|
|
Assignee | |
Comment 4•10 years ago
|
||
Thanks Arthur, this patch was merged into Gaia/master: https://github.com/mozilla-b2g/gaia/commit/6ed44baf39ab28494aef541f32fd1b4795b14aed
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•