Closed Bug 1144541 Opened 9 years ago Closed 6 years ago

[Stingray][Component] Unify package format for smart-banner with other gaia-components

Categories

(Firefox OS Graveyard :: Gaia::TV, defect)

x86
macOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED WONTFIX

People

(Reporter: rexboy, Unassigned)

References

Details

gaia-components/smart-banner currently keeps its original format when it was in smart-components due to historical reasons. We would try to unify it with other gaia-components. Namely:

1. Use unified prefix for tag name. (Still need discuss, in bug 1140973)
2. Use my-component-name.js rather than script.js and style.css
3. Use gaia-components base class (Still need discuss, in bug 1140973)
4. Use UMD wrapper
5. Use Karma and write unit tests.
6. move example page to /index.html
7. Create gh-pages branch for live demo
Blocks: 1218722
No longer blocks: 1218722
Blocks: 1219540
No longer blocks: 1219540
Firefox OS is not being worked on
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.