Closed Bug 1144578 Opened 8 years ago Closed 8 years ago

Intermittent browser_tab_dragdrop.js | Uncaught exception - expected PASS | Found an unexpected tab at the end of test run: data:text/html;charset=utf-8,<body%20onload='clicks=0'%20onclick='++clicks'><embed%20type="application

Categories

(Firefox :: Tabbed Browser, defect)

Product:
Firefox
Component:
Tabbed Browser
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 39
Tracking Flags:
Tracking Status
firefox37 --- unaffected
firefox38 --- unaffected
firefox39 --- fixed
firefox-esr31 --- unaffected

People

(Reporter: cbook, Assigned: mossop)

References

(
URL
)

Details

(Keywords: intermittent-failure)

Attachments

(1 file)

patch
3.95 KB, patch
gkrizsanits
: review+
Details | Diff | Splinter Review 
Rev4 MacOSX Snow Leopard 10.6 mozilla-inbound opt test mochitest-e10s-browser-chrome-1

https://treeherder.mozilla.org/logviewer.html#?job_id=7740986&repo=mozilla-inbound

01:16:27 INFO - 687 INFO TEST-UNEXPECTED-FAIL | browser/base/content/test/general/browser_tab_dragdrop.js | Uncaught exception - expected PASS 

01:16:27 INFO - 699 INFO TEST-UNEXPECTED-FAIL | browser/base/content/test/general/browser_tab_dragdrop.js | Found an unexpected tab at the end of test run: data:text/html;charset=utf-8,<body%20onload='clicks=0'%20onclick='++clicks'><embed%20type="application/x-test"%20allowscriptaccess="always"%20allowfullscreen="true"%20wmode="window"%20width="640"%20height="480"></embed> - expected PASS
Flags: needinfo?(dtownsend)
Attached patch patch — — Splinter Review 
The test throws an exception while trying to do some CPOW stuff so lets avoid that entirely and see what happens. A dozen green try runs suggest good things.
Flags: needinfo?(dtownsend)
Attachment #8583877 - Flags: review?(mconley)
Comment on attachment 8583877 [details] [diff] [review]
patch

gabor just said his review queue is empty. \o/
Attachment #8583877 - Flags: review?(mconley) → review?(gkrizsanits)
Comment on attachment 8583877 [details] [diff] [review]
patch

Review of attachment 8583877 [details] [diff] [review]:
-----------------------------------------------------------------

I would prefer an ObjectValueChecker object with an init and a check methods. But I'm fine with this version as well, just please add a short comment for cacheObjectValue (what it does and why we need it...). Other than that it looks good to me, let's hope this was the last intermittent issue with this test :)
Attachment #8583877 - Flags: review?(gkrizsanits) → review+
Assignee: nobody → dtownsend
https://hg.mozilla.org/mozilla-central/rev/da754eb43be3
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox39: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 39
You need to log in before you can comment on or make changes to this bug.