Closed Bug 1144602 Opened 5 years ago Closed 4 years ago

Intermittent test_rel_preconnect.html | called finish() multiple times or Test timed out

Categories

(Core :: Networking, defect)

x86
macOS
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla41
Tracking Status
firefox38 --- unaffected
firefox38.0.5 --- unaffected
firefox39 --- fixed
firefox40 --- fixed
firefox41 --- fixed
firefox-esr31 --- unaffected
firefox-esr38 --- unaffected

People

(Reporter: cbook, Assigned: mcmanus)

References

()

Details

(Keywords: intermittent-failure)

Rev5 MacOSX Yosemite 10.10 mozilla-inbound debug test mochitest-5

https://treeherder.mozilla.org/logviewer.html#?job_id=7731409&repo=mozilla-inbound

20:34:31 INFO - 1252 INFO TEST-UNEXPECTED-ERROR | netwerk/test/mochitests/test_rel_preconnect.html | called finish() multiple times
Component: DOM → Networking
Summary: Intermittent test_rel_preconnect.html | called finish() multiple times → Intermittent test_rel_preconnect.html | called finish() multiple times or Test timed out
Flags: needinfo?(mcmanus)
I think comment 80 will clear this up.. its plausible the onSocketAccepted events are just in an event queue somewhere and this won't completely help. If that's the case we can add a new state to filter the extras.

in any event I'm pretty confident this is a test-only problem and not a feature problem.
Flags: needinfo?(mcmanus)
https://hg.mozilla.org/mozilla-central/rev/3c4ae7ce532c
Assignee: nobody → mcmanus
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
Still happening :(
Status: RESOLVED → REOPENED
Flags: needinfo?(mcmanus)
Resolution: FIXED → ---
Target Milestone: mozilla41 → ---
https://hg.mozilla.org/mozilla-central/rev/1fd852f33e34
Status: REOPENED → RESOLVED
Closed: 4 years ago4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
Any ideas why we'd see the return of this recently, Patrick?
Flags: needinfo?(mcmanus)
well, its a subset of the previous errors (timed out vs what used to be the much more common called multiple times). Apparently they are not the same cause.

Its probably the same reason https://bugzilla.mozilla.org/show_bug.cgi?id=1174152 bounced. (that bug extends this functionality and test).

My guess is it is not safe to have speculative connect at all enabled during mochitests (and it is normally not - this one enables it because that is what it is testing) .. in at least some cases because it triggers connections to other things than what is being explicitly tested (comment 102, bugzilla.mozilla.org).

Its plausible a xpcshell test could do this safely.
Flags: needinfo?(mcmanus)
You need to log in before you can comment on or make changes to this bug.