1144620 - Fix ReferenceError: RBMozUI is not defined

Status: RESOLVED FIXED

(MozReview Graveyard :: General, defect, P1)

Description

[Mauro Doglio [:mdoglio]]

With the assets minified, try.js raises an error for an undefined variable. This happens because the minification step creates a closure around the js code the defines RBMozUI, making it out of scope in try.js.

Comment 1

[Mauro Doglio [:mdoglio]]

Attachment: MozReview Request: bz://1144620/mdoglio

/r/5593 - Bug 1144620 - Fix ReferenceError: RBMozUI is not defined

Pull down this commit:

hg pull review -r 953393e8f69865395975c728254001d70aff1946

Comment 2

[Steven MacLeod [:smacleod]]

https://reviewboard.mozilla.org/r/5593/#review4765

What we should be doing to fix this instead is put try.js in the same bundle as MozReview. Bundles really shouldn't be per feature, but more so split up based on which pages they need to load in. So if try.js is just loading on the review request page like the rest it should be in the same bundle.

Our js should probably also be using the RB js extensions mechanisms [1][2]. We should clean this up while we migrate to the mozreview extension

[1] https://github.com/djblets/djblets/blob/d6ded53cb178410ac7ed702ce8bd0b48cdc19e84/djblets/extensions/extension.py#L144
[2] https://github.com/djblets/djblets/blob/d6ded53cb178410ac7ed702ce8bd0b48cdc19e84/djblets/extensions/extension.py#L39

Comment 3

[Mauro Doglio [:mdoglio]]

https://reviewboard.mozilla.org/r/5593/#review4795

Ok I'll tackle the the rbmozui migration to mozreview

Comment 5

[Mauro Doglio [:mdoglio]]

Attachment: MozReview Request: Bug 1144620 - Fix ReferenceError: RBMozUI is not defined