1144655 - [Rocketbar] When closing an app with the search opened, it goes back to the search

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Alberto Pastor [:albertopq]]

Not sure if this is a bug, but I wasn't expecting that as a user.

STR:

1.- Open any app with rocketbar (the browser, for example)
2.- Click on the search bar
3.- Longpress the home button, going to the cards view
4.- Close the app

Expected (what I expected, at least):

The search gets closed when longpressing the homebutton and, after closing the app, it goes to the homescreeen

Actual:

After closing the app, it goes back to the search results screen

Comment 1

[Alberto Pastor [:albertopq]]

Francis, could you please confirm if that's the expected behavior? Note that, when switching apps (or going back to the same app) in the cards view during a search, the search does get closed.

Comment 2

[Francis Djabri [:djabber]]

Hi Alberto, 

I agree with your bug. I thought I had this covered in the spec but I'll this case in. If the user invokes the task manager, then the search app should close but maintain its state. 

Thanks, Francis

Comment 3

[GitHub Autolander Bot]

Attachment: [gaia] albertopq:1144655-rocketbar-app > mozilla-b2g:master

Comment 4

[Alberto Pastor [:albertopq]]

Comment on attachment 8583689 [details] [review]
[gaia] albertopq:1144655-rocketbar-app > mozilla-b2g:master

Francis, could you please check if the attached patch implements the expected behavior? Thanks!

Comment 5

[Candice Serran (:cserran)]

not a blocker to release due to edge case

Comment 6

[Francis Djabri [:djabber]]

Looks good to me Alberto, thanks!

Comment 7

[Kevin Grandon :kgrandon]

Comment on attachment 8583689 [details] [review]
[gaia] albertopq:1144655-rocketbar-app > mozilla-b2g:master

lgtm, thanks!

Comment 8

[GitHub Autolander Bot]

https://github.com/mozilla-b2g/gaia/pull/29169

The pull request could not be applied to the integration branch. Please try again after current integration is complete. You may need to rebase your branch against the target branch.

Comment 9

[Kevin Grandon :kgrandon]

(In reply to Autolander from comment #8)
> https://github.com/mozilla-b2g/gaia/pull/29169
> 
> The pull request could not be applied to the integration branch. Please try
> again after current integration is complete. You may need to rebase your
> branch against the target branch.

Doh, this is due to the current integration in bug 1150143. Should be a fairly straightforward rebase after that one lands. (Would prefer to wait for that integration to finish).

Comment 10

[GitHub Autolander Bot]

Pull request has landed in master: https://github.com/mozilla-b2g/gaia/commit/84cbd4391fb7175d5380fa72c04d68873ce77e6d

Comment 11

[KTucker [:KTucker][Inactive 3/4/2016]]

This resolved bug 1159662 on Master. Can we get this uplifted to 2.2?

Comment 12

[Hermes Cheng (inactive after July 27, 2015)]

Gregor,

Could you please help determine if we need to uplift the patch to fix bug 1159662 for 2.2?

Comment 13

[Alberto Pastor [:albertopq]]

Comment on attachment 8583689 [details] [review]
[gaia] albertopq:1144655-rocketbar-app > mozilla-b2g:master

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): -
[User impact] if declined: Keeping the search open while in the cards view, can create weird states like this bug is describing or related to the thumbnails (see 1159662)
[Testing completed]: Unit tests. In master for months.
[Risk to taking this patch] (and alternatives if risky): Given the low complexity of the fix, the tests added, and that has been in master for months without problems, I would say is low risk
[String changes made]: none

Comment 14

[Gregor Wagner [:gwagner]]

Fixes a blocker.

Comment 15

[bhavana bajaj [:bajaj]]

Comment on attachment 8583689 [details] [review]
[gaia] albertopq:1144655-rocketbar-app > mozilla-b2g:master

Given this fixes a blocker , approving this change for 2.2

Comment 16

[GitHub Autolander Bot]

Attachment: [gaia] albertopq:1144655-rocketbar-app-uplift-v2.2 > mozilla-b2g:v2.2

Comment 17

[Ryan VanderMeulen [:RyanVM]]

v2.2: https://github.com/mozilla-b2g/gaia/commit/f88fc90bece38fa8eeb1c57d3b7ab4ad1d5a4159

Comment 19

[Yeojin Chung [:YeojinC]]

This issue is verified fixed on Flame Master and 2.2.

Result: Search screen does not reappear, and the homescreen is displayed properly.

Environmental Variables:
Device: Flame 3.0 (KK, 319mb, full flash)
Build ID: 20150508010203
Gaia: bc5bfa18f795919b56b952bbf3637c235d0e13dc
Gecko: 356e735fa908
Gonk: a9f3f8fb8b0844724de32426b7bcc4e6dc4fa2ed
Version: 40.0a1 (3.0)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:40.0) Gecko/40.0 Firefox/40.0


Environmental Variables:
Device: Flame 2.2 (KK, 319mb, full flash)
Build ID: 20150508002501
Gaia: 88d3ac2721a5484495c2ed60e4a068945f0de5aa
Gecko: 8ad16ebe659d
Gonk: ab265fb203390c70b8f2a054f38cf4b2f2dad70a
Version: 37.0 (2.2)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0