Use peep for deployment and remove vendor submodules

VERIFIED FIXED

Status

www.mozilla.org
Bedrock
VERIFIED FIXED
3 years ago
3 years ago

People

(Reporter: pmac, Unassigned)

Tracking

Production

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [kb=1709913] )

Use requirements files and peep[0] for management of requirements. They should be installed into the virtualenv during deployment. This will also allow us to remove the path munging done by funfactory, which may mean also removing funfactory as a dependency and moving the parts of it we need into bedrock (much like fjord did[1]).

[0] https://github.com/erikrose/peep
[1] https://github.com/mozilla/fjord/commit/9d7c97b

Updated

3 years ago
Whiteboard: [kb=1709913]

Comment 1

3 years ago
Commits pushed to master at https://github.com/mozilla/bedrock

https://github.com/mozilla/bedrock/commit/9faa0e3223e9057e0f8ad3243623a93fb542cb94
Fix bug 1144669: Remove vendor submodules and use peep.

Use peep (a pip wrapper) for installation of dependencies
into the virtualenv already setup for deployment.

https://github.com/mozilla/bedrock/commit/ec97cca564e60105d0506c58716e8f6e8334cb78
Bug 1144669: Update deployment for peep dependencies.

Fix CI and C9 and add relocatable to deployment

https://github.com/mozilla/bedrock/commit/78b870355de47a70279bbe33d91286b802935ab5
Merge pull request #2898 from pmclanahan/vendor-to-peep-1144669

Fix bug 1144669: Remove vendor submodules and use peep.

Updated

3 years ago
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED

Comment 2

3 years ago
We deployed the commits in comment #1 to prod this morning, and after several hours no new issues have arisen. All of the vendor submodules are gone; there is one git submodule remaining in the vendor-local directory, the removal of which is being tracked in bug 1154466.
Status: RESOLVED → VERIFIED

Updated

3 years ago
See Also: → bug 1154466
Blocks: 1155810
You need to log in before you can comment on or make changes to this bug.