Closed Bug 1144692 Opened 5 years ago Closed 5 years ago

Fix --disable-ion builds

Categories

(Core :: JavaScript Engine: JIT, defect)

x86_64
Linux
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla39
Tracking Status
firefox39 --- fixed

People

(Reporter: bbouvier, Assigned: bbouvier)

Details

Attachments

(1 file)

I think ted asked for this recently on jsapi...
This patch adds a few missing methods and changes the registers in none/ so that register set assertions don't blow up (context: not a single jit-test was passing with the --disable-ion option because of the register set assertions in code() in jit/Registers.h).
Attachment #8579387 - Flags: review?(hv1989)
Comment on attachment 8579387 [details] [diff] [review]
fix-ion-builds.patch

Review of attachment 8579387 [details] [diff] [review]:
-----------------------------------------------------------------

r+ with requested changes.

::: js/src/jit/none/MacroAssembler-none.h
@@ +61,4 @@
>  
> +static MOZ_CONSTEXPR_VAR Register JSReturnReg_Type = { Registers::r0 };
> +static MOZ_CONSTEXPR_VAR Register JSReturnReg_Data = { Registers::r0 };
> +static MOZ_CONSTEXPR_VAR Register JSReturnReg = { Registers::r0 };

I would prefer to keep this "invalid_reg"!

Instead can you move the definition of "EntryTempMask" inside the only functions that needs it? So inside "generateArgumentsChecks"?

That solves it locally.
Attachment #8579387 - Flags: review?(hv1989) → review+
(In reply to Hannes Verschore [:h4writer] from comment #1)
> Instead can you move the definition of "EntryTempMask" inside the only
> functions that needs it? So inside "generateArgumentsChecks"?
Indeed simpler!

(no try build, this isn't actually tested on tbpl)
https://hg.mozilla.org/integration/mozilla-inbound/rev/ec8f020d47ae
Assignee: nobody → benj
Status: NEW → ASSIGNED
Flags: in-testsuite-
https://hg.mozilla.org/mozilla-central/rev/ec8f020d47ae
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla39
You need to log in before you can comment on or make changes to this bug.