1144708 - unlisted addons can be reviewed in the editor tools

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Developer Pages, defect)

Description

[Mathieu Agopian [:magopian]]

unlisted addons can be reviewed in the editor tools:
- the review page should work
- links to the "content" (browse files), "All platforms" (download file) and "validation" (report) should work
- link to the "admin page" should work
- link to the "edit page" should work (brings to the devhub addon page)
- all links related to "view listing" should be removed

Comment 1

[Mathieu Agopian [:magopian]]

Links related to "view listing" aren't removed, but changed to point to the devhub

Comment 2

[Mathieu Agopian [:magopian]]

Scrap last comment: there's already a "edit (admin)" link that brings to the devhub page of the addon, if it's an admin viewing the page. The "View listing" should go, because only admins would be able to use it (and they already have the "edit" link).

Comment 3

[Mathieu Agopian [:magopian]]

PR: https://github.com/mozilla/olympia/pull/490

Comment 4

[Mathieu Agopian [:magopian]]

Fixed in https://github.com/mozilla/olympia/commit/a993e90656ca7ca018afba0b9b6b11aa15a918cf

Comment 5

[Madalin Cotetiu]

Verified as fixed in FF37(Win7) in addons-dev.allizom.org
Verified all the scenarios from comment 0.
Closing bug.