If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Feedback screenshot does not include status bar

RESOLVED WONTFIX

Status

()

Firefox for iOS
Build & Test
RESOLVED WONTFIX
3 years ago
3 months ago

People

(Reporter: st3fan, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(4 attachments, 1 obsolete attachment)

(Reporter)

Description

3 years ago
I made a quick fix for bug 1144683 - Feedback screenshot is empty, that uses a different method of taking a screenshot. This works except that the status bar is not included. I think it would be nice if we can fix that.

Comment 1

2 years ago
Created attachment 8699163 [details]
ipad-before-screenshot.png

Comment 2

2 years ago
Created attachment 8699164 [details]
ipad-after-screenshot.png

Comment 3

2 years ago
Created attachment 8699165 [details]
iphone-before-screenshot.png

Comment 4

2 years ago
Created attachment 8699166 [details]
iphone-after-screenshot.png

Comment 5

2 years ago
Created attachment 8699169 [details] [review]
Pull request

The only way I found for including the status bar in the screenshot is using UIScreen's snapshotViewAfterScreenUpdates method. However, while testing on the simulator I saw a few graphical glitches (see attached screenshots). It could be a simulator thing but, unfortunately, I cannot verify this assumption as I cannot build to a device due to missing provisioning profiles.

Generally, using UIWindow's drawViewHierarchyInRect method did produce better results on the simulator (but without including the status bar). I also tried to combine both approaches by rendering on top of each other but this breaks in a multi-tasking scenario because there seems to be no way to determine the application windows' position on the screen (snapshotViewAfterScreenUpdates will capture the whole screen and the window could be in the left or right pane).
Attachment #8699169 - Flags: review?(sarentz)
(Reporter)

Comment 6

2 years ago
We can test this PR branch on a few devices to see how it works there. We all also have 8.x devices too.

Aaron, do you have the ability to run this on a device and see if it makes a difference?
Flags: needinfo?(aaron.train)
(Reporter)

Comment 7

2 years ago
The code looks fine. Just want to be sure it makes an actual difference.
(Reporter)

Comment 8

2 years ago
Hennes, I just tried on my iPhone 6s and the screenshot is completely blank. Not sure what is going on there.

Looping in :sleroux because he may remember some of the details of screenshotting when he did the first version of this.
Flags: needinfo?(sleroux)
(Reporter)

Comment 9

2 years ago
Comment on attachment 8699169 [details] [review]
Pull request

Switching reviewers.
Attachment #8699169 - Flags: review?(sarentz) → review?(sleroux)
I'm seeing the feedback image blank as well on my iPhone 6. Not sure what's causing it though. When I first implemented the screenshot logic I don't remember having a reason for using snapshotViewAfterScreenUpdates over drawViewHierarchy in rect. Actually I don't remember if the status bar was showing in the first implementation or not.
Flags: needinfo?(sleroux)

Updated

2 years ago
Flags: needinfo?(aaron.train)
Saw the same

Comment 12

2 years ago
Sorry, I forgot to add myself to the CC list so I didn't get any update notifications on this ticket. It's weird that it doesn't work at all on the device but at least to some extent on the simulator. I guess using snapshotViewAfterScreenUpdates is not a valid option then. :(
Hey hennes,

Did you still want to work on this? I was going to mark the current PR as obsolete if you wanted to give it another go.
Flags: needinfo?(johannesmarbach)

Comment 14

2 years ago
Stephan, sorry, I'm currently out of ideas here. The current PR is definitely obsolete because it doesn't seem to work at all on a device. I'm not aware of any other options, sadly.
Flags: needinfo?(johannesmarbach)

Updated

2 years ago
Attachment #8699169 - Attachment is obsolete: true
Attachment #8699169 - Flags: review?(sleroux)
Status: NEW → RESOLVED
Last Resolved: 3 months ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.