1144713 - Flame: the Time Format setting is incorrect in Settings -> Date & Time

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[No-Jun Park [:njpark]]

STR:
- Open Settings -> Date & Time
- Disable 'Set Automatically', and change time to 9:00 PM
- Change the Time Format to 12-hour, and back to 24-hour

Expected:
When 12-hour is selected: 9:00 PM is shown on the status bar
When 24-hour is selected: 21:00 is shown on the status bar
Actual:
Above expectation is reversed

Version info:
Gaia-Rev        3f75f6262bac8f0ca7a26769f78d0849ba6bf2f0
Gecko-Rev       https://hg.mozilla.org/integration/b2g-inbound/rev/3cf75bcf7e1a
Build-ID        20150318055905
Version         39.0a1
Device-Name     flame
FW-Release      4.4.2
FW-Incremental  eng.cltbld.20150318.092819
FW-Date         Wed Mar 18 09:28:30 EDT 2015
Bootloader      L1TC000118D0

Comment 1

[No-Jun Park [:njpark]]

To reproduce more reliably, when in the Time Format menu, change the time format (12/24hr) multiple times

Comment 2

[Pi Wei Cheng [:piwei] (inactive)]

I think the bug here is that the status bar does NOT reflect time change or time format change until certain action is performed.

When I did step 2, the status bar simply ignored my time change until I did step 3, and after step 3 if I lock the device and unlock it will force the status bar to reflect the time format.

------

This issue does NOT occur on Flame 2.2. Time change or time format change at step 2 or step 3 is immediately reflected on status bar.

Device: Flame 2.2 (shallow flash 319MB mem)
BuildID: 20150318075645
Gaia: 6a58c433c53c25e96e067a9b38bf1cc17307d5b2
Gecko: 70b8707bc5d2
Version: 37.0 (2.2) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0

Working on getting the window now.

Comment 3

[No-Jun Park [:njpark]]

(In reply to Pi Wei Cheng [:piwei] from comment #2)
> I think the bug here is that the status bar does NOT reflect time change or
> time format change until certain action is performed.
> 
> When I did step 2, the status bar simply ignored my time change until I did
> step 3, and after step 3 if I lock the device and unlock it will force the
> status bar to reflect the time format.
> 

Makes sense. I think the status bar is one step behind what I do on the settings, eventually making it look like it's showing the opposite time format.

Comment 4

[No-Jun Park [:njpark]]

[Blocking Requested - why for this release]:
Time change is not reflected in the status bar immediately unless there is some other UX change, causing user confusion.

Comment 5

[Pi Wei Cheng [:piwei] (inactive)]

b2g-inbound regression window:

Last Working Environmental Variables:
Device: Flame
BuildID: 20150303023847
Gaia: 6036295b7192e21c1370495617e5ab727575fea3
Gecko: 97c49ccbdfbf
Version: 39.0a1 (3.0 Master)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:39.0) Gecko/39.0 Firefox/39.0

First Broken Environmental Variables:
Device: Flame
BuildID: 20150303025447
Gaia: d9399ecd386aaf37214c4bffcaceca335c143413
Gecko: 11a4ffbd9ee9
Version: 39.0a1 (3.0 Master)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:39.0) Gecko/39.0 Firefox/39.0

Last Working Gaia & First Broken Gecko - issue does NOT repro
Gaia: 6036295b7192e21c1370495617e5ab727575fea3
Gecko: 11a4ffbd9ee9

Last Working Gecko & First Broken Gaia - issue DOES repro
Gaia: d9399ecd386aaf37214c4bffcaceca335c143413
Gecko: 97c49ccbdfbf

Gaia pushlog:
https://github.com/mozilla-b2g/gaia/compare/6036295b7192e21c1370495617e5ab727575fea3...d9399ecd386aaf37214c4bffcaceca335c143413

Caused by Bug 1098168.

Comment 6

[KTucker [:KTucker][Inactive 3/4/2016]]

Alive, can you take a look at this please? This looks to be caused by the landing for bug 1098168.

Comment 7

[(inactive after 6/18) Alive Kuo [:alive]]

Sure, thanks!

Comment 8

[GitHub Autolander Bot]

Attachment: [gaia] alivedise:bugzilla/1144713/time-format-change-reflect > mozilla-b2g:master

Comment 9

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8580504 [details] [review]
[gaia] alivedise:bugzilla/1144713/time-format-change-reflect > mozilla-b2g:master

Simple one

Comment 10

[Etienne Segonzac (:etienne)]

Comment on attachment 8580504 [details] [review]
[gaia] alivedise:bugzilla/1144713/time-format-change-reflect > mozilla-b2g:master

lgtm

Comment 11

[(inactive after 6/18) Alive Kuo [:alive]]

https://github.com/mozilla-b2g/gaia/commit/8eac260ee81a8aca05770d18c5736536d44ee7a7

Comment 12

[helen（leave from Mozilla）]

Attachment: v3.0.3gp

This bug has been verified as pass on latest build of Flame v3.0 & Nexus 5 v3.0 by the STR in Comment 0. 

Results:
When 12-hour is selected: 9:00 PM is shown on the status bar. When 24-hour is selected: 21:00 is shown on the status bar.

See attachment: v3.0.3gp
Reproduce rate: 0/15

Device: Flame v3.0(verified)
Build ID               20150617160207
Gaia Revision          b404c41c5471c31610e64defb74ec066b411e724
Gaia Date              2015-06-17 17:01:15
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/a3f280b6f8d5
Gecko Version          41.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150617.192003
Firmware Date          Wed Jun 17 19:20:14 EDT 2015
Bootloader             L1TC000118D0

Device: Nexus5 3.0 (verified)
Build ID               20150617160207
Gaia Revision          b404c41c5471c31610e64defb74ec066b411e724
Gaia Date              2015-06-17 17:01:15
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/a3f280b6f8d5
Gecko Version          41.0a1
Device Name            hammerhead
Firmware(Release)      5.1
Firmware(Incremental)  eng.cltbld.20150617.192258
Firmware Date          Wed Jun 17 19:23:17 EDT 2015
Bootloader             HHZ12f