114475 - primary toolbar button/icon appears in the wrong order on first window

Status: VERIFIED FIXED

(SeaMonkey :: Themes, defect)

Description

[sairuh (rarely reading bugmail)]

not sure if this is limited to linux, or the editor app. seen using
2001.12.10.08 comm bits on rh7.2.

basically, the editor app icon sometimes appears in the middle of the toolbar.
wacky. will attach screenshot soon.

Comment 1

[sairuh (rarely reading bugmail)]

Attachment: screenshot

Comment 2

[:deanis74]

Looks fine on windows on 2001121003.

Comment 3

[Joe Hewitt (gone)]

This happens in Navigator also, the print button sometimes appears before the
urlbar.  This only happens to Nav and Editor if they are the first window you
open when starting mozilla - all subsequent windows are fine.

This occurred when I simplified the anonymous content for the modern primary
toolbar binding, but nothing is wrong with the binding.  XBL seems to be getting
confused.

Comment 4

[Charles Manske]

I'm so glad others are finally seeing this! It's very wacky.
Here are the order of buttons according to our XUL:
    <toolbarbutton id="newButton"/>
    <toolbarbutton id="openButton"/>
    <toolbarbutton id="saveButton"/>
    <toolbarbutton id="previewButton"/>
    <toolbarbutton id="printButton" />
    <toolbarbutton id="spellingButton"/>
    <toolbarseparator class="toolbarseparator-primary"/>
    <toolbarbutton id="imageButton"/>
    <toolbarbutton id="hlineButton"/>
    <toolbarbutton id="tableButton"/>
    <toolbarbutton id="linkButton"/>
    <toolbarbutton id="namedAnchorButton"/>

But the order of buttons in my debug build is just as shown in the screenshot:
New, Save, Print [Composer Graphic],Open, Browse, Spell, Image, Table, Anchor, 
Hline, Link.
The most noticeable difference is the location of the "Composer Graphic", which
is supposed to be at the beginning, but as you can see the order is really
completely scrambled!

Comment 5

[Joe Hewitt (gone)]

I have a workaround for the xbl bug that I am going to check in.  Don't have
time to fix the xbl problem before 0.9.7, and it's not trivial.

Comment 6

[Joe Hewitt (gone)]

Attachment: patch

Comment 7

[Charles Manske]

Comment on attachment 62034 [details] [diff] [review]
patch

r=cmanske 
Works for me!

Comment 8

[sairuh (rarely reading bugmail)]

hey, this is now working for both me and patty! ie, using 2001.12.18.08 comm
bits on linux.

was this checked in, and should this be resolved?

Comment 9

[Joe Hewitt (gone)]

fixed on trunk and branch

Comment 10

[Patty Mac]

Verified on linux (2001-12-20-08-trunk)