1144777 - A website with a theme colour has the incorrect style when first opened

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::System::Browser Chrome, defect)

Description

[Guillaume Marty [:gmarty]]

Attachment: 2015-03-18-13-09-26.png

Close all browser windows, open a website with a light theme colour.
The icons are dark and the minimised title bar has a bad style.

This works correctly as soon as a link in the page is pressed. Very likely a regression.

Comment 1

[Guillaume Marty [:gmarty]]

Attachment: 2015-03-18-13-09-38.png

Comment 2

[Gregor Wagner [:gwagner]]

Can we do a branch check?

Comment 3

[Shally Li（leave from Mozilla）]

Hi Reproter,

    I only can repro that both the status bar and search bar are stuffed into the same color as the website theme color,but no dark icons on status bar on Flame v2.2&3.0. 
    Could you help to provide more detailed reproduce steps? 

Thank you very much.
---------------------------------------------------------------------
Rate:5/5
Attachment:verify_v3.0&2.0.mp4 and logcat_1507.txt.

Repro STR:
1.Launch Browser app.
2.Enter url "http://gu.illau.me/".
**Both the status bar and search bar are stuffed into the same color as the website theme color (saffron yellow).  --KO
3.Slide down or slide up.
**The minimised search bar and icons on status bar is not overlapped and display normally.  --OK

Flame 2.2 build:
Build ID               20150319002500
Gaia Revision          9043c11f699c15bb6072422d1dad6518d1b5ddda
Gaia Date              2015-03-19 01:40:44
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/c0442d170bec
Gecko Version          37.0
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150319.042028
Firmware Date          Thu Mar 19 04:20:38 EDT 2015
Bootloader             L1TC000118D0

Flame 3.0 build:
Build ID               20150319160212
Gaia Revision          c39e15f631de80c69467fda0d4ea0bcda9e194ca
Gaia Date              2015-03-18 19:30:04
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/cbd0efcd976c
Gecko Version          39.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150319.193329
Firmware Date          Thu Mar 19 19:33:42 EDT 2015
Bootloader             L1TC000118D0

Comment 4

[Shally Li（leave from Mozilla）]

Attachment: logcat_1507.txt

Comment 5

[Shally Li（leave from Mozilla）]

Attachment: verify_v3.0&2.0.mp4

Comment 6

[Pi Wei Cheng [:piwei] (inactive)]

STR:
1) Open browser and go to http://gu.illau.me
2) Add this website to Homescreen
3) Long pressing Home button and kill all tasks
4) Tap on the bookmark/app added at step 2

Expected: Status bar and rocketbar items display as white colored

Actual: Status bar and rocketbar items display as gray colored

This issue occurs on Flame 3.0, Flame 2.2.

Device: Flame 3.0
BuildID: 20150320010204
Gaia: 8837f94418d69a0b06c1f4843b0779e2bb72165a
Gecko: 4d2d97b3ba34
Gonk: b83fc73de7b64594cd74b33e498bf08332b5d87b
Version: 39.0a1 (3.0) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:39.0) Gecko/39.0 Firefox/39.0

Device: Flame 2.2
BuildID: 20150320002502
Gaia: c8136ef4094fc5509551ab7b1d5f6141491f00ef
Gecko: 12139abae350
Gonk: ebad7da532429a6f5efadc00bf6ad8a41288a429
Version: 37.0 (2.2) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0

------

This issue does NOT occur on Flame 2.1. Expected behavior is observed.

Device: Flame 2.1
BuildID: 20150320001203
Gaia: 13c85d57f49b4bfd657ff674f2b530c141c94803
Gecko: 76bf2f0c7f07
Gonk: b83fc73de7b64594cd74b33e498bf08332b5d87b
Version: 34.0 (2.1) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

Comment 7

[Guillaume Marty [:gmarty]]

Thanks for the video. To reproduce the bug you need to actually use the Rocket bar and not launch the browser app beforehand. Also, make sure all browsers instances are killed.

Comment 8

[Pi Wei Cheng [:piwei] (inactive)]

b2g-inbound regression window:

Last Working Environmental Variables:
Device: Flame
BuildID: 20150128133230
Gaia: 03a38bd5255747a06c276029bceb61dcd6f5568b
Gecko: 26d511f0b771
Version: 38.0a1 (3.0 Master)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:38.0) Gecko/38.0 Firefox/38.0

First Broken Environmental Variables:
Device: Flame
BuildID: 20150128135232
Gaia: 57b455f62bdac4b614b9135123dc7ef896df4833
Gecko: 6f36fd4724c5
Version: 38.0a1 (3.0 Master)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:38.0) Gecko/38.0 Firefox/38.0

Last Working Gaia & First Broken Gecko - issue does NOT repro
Gaia: 03a38bd5255747a06c276029bceb61dcd6f5568b
Gecko: 6f36fd4724c5

Last Working Gecko & First Broken Gaia - issue DOES repro
Gaia: 57b455f62bdac4b614b9135123dc7ef896df4833
Gecko: 26d511f0b771

Gaia pushlog:
https://github.com/mozilla-b2g/gaia/compare/03a38bd5255747a06c276029bceb61dcd6f5568b...57b455f62bdac4b614b9135123dc7ef896df4833

Caused by the patch for Bug 1118361.

Comment 9

[KTucker [:KTucker][Inactive 3/4/2016]]

Brian, can you take a look at this please? This looks to have been caused by the uplift and landing for bug 1118361

Comment 10

[Brian Birtles (:birtles, Feb 26~ parental leave)]

I'm currently setting up a 2.2 build environment to repro this. In the meantime I can't view the video (attachment 8580551 [details]) on Windows: "Video can't be played because the file is corrupt". Any chance of a webm/youtube version?

Comment 11

[Brian Birtles (:birtles, Feb 26~ parental leave)]

(In reply to Brian Birtles (:birtles) from comment #10)
> I'm currently setting up a 2.2 build environment to repro this. In the
> meantime I can't view the video (attachment 8580551 [details]) on Windows:
> "Video can't be played because the file is corrupt". Any chance of a
> webm/youtube version?

Never mind, I can reproduce now.

Comment 12

[GitHub Autolander Bot]

Attachment: [gaia] birtles:ignore-unrelated-transitions-v2 > mozilla-b2g:master

Comment 13

[Kevin Grandon :kgrandon]

Comment on attachment 8582237 [details] [review]
[gaia] birtles:ignore-unrelated-transitions-v2 > mozilla-b2g:master

This looks good to me. Nice find, and thank you for the patch.

We do generally want to squash commits in gaia before landing into a single commit. You can do so using the 'git rebase' command.

Comment 14

[GitHub Autolander Bot]

Attachment: [gaia] birtles:ignore-unrelated-transitions-squashed > mozilla-b2g:master

Comment 15

[Brian Birtles (:birtles, Feb 26~ parental leave)]

Thanks Kevin! I've squashed up the commits and re-attached (still trying to work out how you manage multiple patch fixes in Gaia-land).

Comment 16

[Kevin Grandon :kgrandon]

Comment on attachment 8582768 [details] [review]
[gaia] birtles:ignore-unrelated-transitions-squashed > mozilla-b2g:master

(In reply to Brian Birtles (:birtles) from comment #15)
> Thanks Kevin! I've squashed up the commits and re-attached (still trying to
> work out how you manage multiple patch fixes in Gaia-land).

We generally just have a rule of one patch per bug in gaia, which I can see as being a bit weird for someone new to the system. Not really sure if it's still relevant, but it's what they've been doing since the beginning.

Going to add a R+ here. I think that should kick autolander as it's a new PR.

Comment 17

[GitHub Autolander Bot]

Autolander could not locate a review from a user within the suggested reviewer list. Either the patch author or the reviewer should be in the suggested reviewer list.

Comment 18

[GitHub Autolander Bot]

Pull request has landed in master: https://github.com/mozilla-b2g/gaia/commit/419b6873b4dc310e0099ba269dd5364985b76539

Comment 19

[Kevin Grandon :kgrandon]

So this seems to have started causing Gip functional test failures on b-i, although the try run seems ok. I need to look into this and figure out why this is not failing the try run, I know the suites on b-i currently differ from try, and we are looking at fixing this soon.

TH log: https://treeherder.mozilla.org/logviewer.html#?job_id=1572078&repo=b2g-inbound
Backout: https://github.com/mozilla-b2g/gaia/commit/3becdffa4e506dadeed9f2e352a369dc8b5ccf10

Leaving a needinfo on myself to validate that this fixes it and figure out what's wrong with the tests.

Comment 20

[Legacy TBPL/Treeherder Robot]

log: https://treeherder.mozilla.org/logviewer.html#?repo=b2g-inbound&job_id=1573305
repository: b2g-inbound
start_time: 2015-03-24T21:27:13
who: kgrandon[at]mozilla[dot]com
machine: tst-linux64-spot-817
buildname: b2g_ubuntu64_vm b2g-inbound opt test gaia-ui-test-functional-3
revision: 4602d2a79ef4

TEST-UNEXPECTED-ERROR | test_keyboard_predictive_key.py TestKeyboardPredictiveKey.test_keyboard_predictive_key | TimeoutException: TimeoutException: Timed out after 10.2 seconds
Return code: 10

Comment 21

[Legacy TBPL/Treeherder Robot]

log: https://treeherder.mozilla.org/logviewer.html#?repo=b2g-inbound&job_id=1573378
repository: b2g-inbound
start_time: 2015-03-24T21:36:08
who: kgrandon[at]mozilla[dot]com
machine: tst-linux64-spot-1077
buildname: b2g_ubuntu64_vm b2g-inbound opt test gaia-ui-test-functional-3
revision: 3f8b6699406d

TEST-UNEXPECTED-ERROR | test_keyboard_predictive_key.py TestKeyboardPredictiveKey.test_keyboard_predictive_key | TimeoutException: TimeoutException: Timed out after 10.1 seconds
Return code: 10

Comment 22

[Legacy TBPL/Treeherder Robot]

log: https://treeherder.mozilla.org/logviewer.html#?repo=b2g-inbound&job_id=1572111
repository: b2g-inbound
start_time: 2015-03-24T19:39:20
who: kgrandon[at]mozilla[dot]com
machine: tst-linux64-spot-1303
buildname: b2g_ubuntu64_vm b2g-inbound opt test gaia-ui-test-functional-3
revision: 771b34ea0153

TEST-UNEXPECTED-ERROR | test_keyboard_predictive_key.py TestKeyboardPredictiveKey.test_keyboard_predictive_key | TimeoutException: TimeoutException: Timed out after 10.1 seconds
Return code: 10

Comment 23

[Legacy TBPL/Treeherder Robot]

log: https://treeherder.mozilla.org/logviewer.html#?repo=b2g-inbound&job_id=1572078
repository: b2g-inbound
start_time: 2015-03-24T18:52:36
who: kgrandon[at]mozilla[dot]com
machine: tst-linux64-spot-1612
buildname: b2g_ubuntu64_vm b2g-inbound opt test gaia-ui-test-functional-3
revision: f037e9c31eed

TEST-UNEXPECTED-ERROR | test_keyboard_predictive_key.py TestKeyboardPredictiveKey.test_keyboard_predictive_key | TimeoutException: TimeoutException: Timed out after 10.1 seconds
Return code: 10

Comment 24

[Legacy TBPL/Treeherder Robot]

log: https://treeherder.mozilla.org/logviewer.html#?repo=b2g-inbound&job_id=1572867
repository: b2g-inbound
start_time: 2015-03-24T20:41:26
who: kgrandon[at]mozilla[dot]com
machine: tst-linux64-spot-1509
buildname: b2g_ubuntu64_vm b2g-inbound opt test gaia-ui-test-functional-3
revision: 7690d9e5ba8a

TEST-UNEXPECTED-ERROR | test_keyboard_predictive_key.py TestKeyboardPredictiveKey.test_keyboard_predictive_key | TimeoutException: TimeoutException: Timed out after 10.2 seconds
Return code: 10

Comment 25

[Kevin Grandon :kgrandon]

Sorry for the noise here. The error seems to have cleared up here (https://treeherder.mozilla.org/#/jobs?repo=b2g-inbound&revision=b0f41fafb958) before the revert got in, so I'm not really sure what's going on.

For now I'm going to re-land this as it seems the error was not caused by this: https://github.com/mozilla-b2g/gaia/commit/5499ff2fa9f4fa3a63ec368ee4ff2728737f9858

Comment 26

[GitHub Autolander Bot]

Attachment: [gaia] birtles:ignore-unrelated-transitions-v2 > mozilla-b2g:master

Comment 27

[Brian Birtles (:birtles, Feb 26~ parental leave)]

Comment on attachment 8582768 [details] [review]
[gaia] birtles:ignore-unrelated-transitions-squashed > mozilla-b2g:master

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): bug 1118361
[User impact] if declined: Status bar icons and text are hard to read for some websites.
[Testing completed]: Has had about 1 day of bake time on trunk. Includes tests.
[Risk to taking this patch] (and alternatives if risky): Minimal.
[String changes made]: None.

Comment 28

[Ryan VanderMeulen [:RyanVM]]

v2.2: https://github.com/mozilla-b2g/gaia/commit/d44386d6e65fb522fd93dc58a1aba27377742fdd

Comment 29

[Shally Li（leave from Mozilla）]

This bug has been successfully verified on latest Nightly Flame v3.0.
See attachment: verified_v3.0.mp4
Reproduce rate: 0/5

STR:
1. Open Browser and go to "http://gu.illau.me".
**Status bar and rocketbar items display as white colored.  --OK
2. Add this website to Homescreen.
3. Long press Home button and kill all tasks.
4. Tap on the website icon on homescreen.
**Status bar icons and rocketbar items display as white color,and they are not overlapped.  --OK

Device: Flame 3.0 build(Pass)
Build ID               20150326160206
Gaia Revision          525c341254e08f07f90da57a4d1cd5971a3cc668
Gaia Date              2015-03-26 16:34:16
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/59554288b4eb
Gecko Version          39.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150326.193247
Firmware Date          Thu Mar 26 19:32:58 EDT 2015
Bootloader             L1TC000118D0

Comment 30

[Shally Li（leave from Mozilla）]

Attachment: verified_v3.0.mp4

Comment 31

[Shally Li（leave from Mozilla）]

This bug has been successfully verified on latest Nightly Flame v2.2 by the STR of Comment 29 (Rate: 0/5).
Actual Result: Status bar icons and rocketbar items display as white color,and they are not overlapped.

Device: Flame 2.2 build(Pass)
Build ID               20150327162502
Gaia Revision          473cd63f53c855299b719285d9b95e3f2910782f
Gaia Date              2015-03-27 20:14:43
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/b358619def45
Gecko Version          37.0
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150327.194944
Firmware Date          Fri Mar 27 19:49:53 EDT 2015
Bootloader             L1TC000118D0