Closed Bug 1144779 Opened 5 years ago Closed 5 years ago
Do not use mouse coordinates from on
Mouse Up to set selection end when dragging in Graph
Right now the coordinates from the mouseup event are used to finalize the selection in the Graph. This can cause weirdness when a mouseup happens outside of the toolbox and then it is triggered from the next mousemove. STR: Start a new selection on graph Move the mouse up to the browser content Release mouse Move the mouse back into the timeline Notice that the selection ends at the location of the mouse currently, when it should stay where it was when the mouse went up. Dragging and resizing an existing selection doesn't have this behavior, because the coordinates are used from mousemove instead.
What do you think?
Assignee: nobody → bgrinstead
Status: NEW → ASSIGNED
Comment on attachment 8579478 [details] [diff] [review] timeline-mouseup.patch Forgot to flag r?
5 years ago
Comment on attachment 8579478 [details] [diff] [review] timeline-mouseup.patch Review of attachment 8579478 [details] [diff] [review]: ----------------------------------------------------------------- Need to fix bug 1066504 first. Sorry!
Moving into the Profiler component. Filter on GUTHRIE'S WAVY CAKES.
Component: Developer Tools: Timeline → Developer Tools: Profiler
Brian, are you still planning on looking at these bugs? ( https://bugzilla.mozilla.org/showdependencytree.cgi?id=1147941&hide_resolved=1 )
(In reply to Victor Porof [:vporof][:vp] from comment #5) > Brian, are you still planning on looking at these bugs? ( > https://bugzilla.mozilla.org/showdependencytree. > cgi?id=1147941&hide_resolved=1 ) Yes, I'll take a look at this
I don't think this is as big of a deal anymore with Bug 1145784 fixed. I'm not positive if there is still a case where the mouseup event will be skipped when bound to the top level window. Some quick testing shows that the mouseup event fires even when I release it outside of the browser, but I'm not sure if that's dependent on the platform / window manager. I think this will be a quick, easy fix so I'll proceed with a patch.
Depends on: 1145784
Don't use event coordinates from mouseup. Try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=1ee94157fbe4
Attachment #8602287 - Flags: review?(vporof) → review+
Also, thank you Brian for tackling those selection bugs!
5 years ago
You need to log in before you can comment on or make changes to this bug.