Closed Bug 1144791 Opened 11 years ago Closed 11 years ago

Don't expect favicon.ico to be collected

Categories

(Socorro :: Webapp, task)

Product:
Socorro
Component:
Webapp
Platform:
x86
macOS
Type:
task
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: peterbe, Assigned: peterbe)

Details

If you have NOT run `./manage.py collectstatic --noinput` or you have deleted the `webapp-django/static` directory you get a IOError because the crashstats.crashstats.views.favicon_ico view assumes you've run collectstatic. This makes it quite impractical to switch between development mode (where you want to edit .js files and see changes without having to run the collectstatic step every time)
Assignee: nobody → peterbe
Status: NEW → ASSIGNED
Commits pushed to master at https://github.com/mozilla/socorro https://github.com/mozilla/socorro/commit/6ef976ff350ef66e968479b563fe7ab80f78544f fixes bug 1144791 - Don't expect favicon.ico to be collected https://github.com/mozilla/socorro/commit/3f585257167c5381b17f2511578786e875d9ef91 Merge pull request #2674 from peterbe/bug-1144791-dont-expect-faviconico-to-be-collected fixes bug 1144791 - Don't expect favicon.ico to be collected
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Commits pushed to master at https://github.com/mozilla/socorro https://github.com/mozilla/socorro/commit/f6e1edf5c5a0c3d4d604958a5195faf48b16c676 Revert "fixes bug 1144791 - Don't expect favicon.ico to be collected" https://github.com/mozilla/socorro/commit/f6eeb647fbf0f7e691961392aa2431d546b96f42 Merge pull request #2676 from mozilla/revert-2674-bug-1144791-dont-expect-faviconico-to-be-collected Revert "fixes bug 1144791 - Don't expect favicon.ico to be collected"
I had to revert this because it was breaking the build on jenkins. https://ci.mozilla.org/job/socorro-release/1652/console 03:46:37 FAIL: test_favicon (crashstats.crashstats.tests.test_views.FaviconTestViews) 03:46:37 ---------------------------------------------------------------------- 03:46:37 Traceback (most recent call last): 03:46:37 File "/var/lib/jenkins/jobs/socorro-release/workspace/webapp-django/crashstats/crashstats/tests/test_views.py", line 269, in test_favicon 03:46:37 eq_(response['Content-Type'], 'image/x-icon') 03:46:37 AssertionError: 'image/vnd.microsoft.icon' != 'image/x-icon'
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
New PR https://github.com/mozilla/socorro/pull/2677
Status: REOPENED → ASSIGNED
Commits pushed to master at https://github.com/mozilla/socorro https://github.com/mozilla/socorro/commit/43fb585ee81383f20ee16976bfdc9b2a63cd3ca5 fixes bug 1144791 - favicon.ico straight from django https://github.com/mozilla/socorro/commit/26ffdd1207278e6fb556b4a60062a22de585d566 Merge pull request #2677 from peterbe/bug-1144791-faviconico-straight-from-django fixes bug 1144791 - favicon.ico straight from django
Status: ASSIGNED → RESOLVED
Closed: 11 years ago → 11 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.