Closed Bug 1144799 Opened 9 years ago Closed 9 years ago

Only allow the mouseup callback to run on the Graph if a drag is currently active

Categories

(DevTools :: Performance Tools (Profiler/Timeline), defect, P2)

Product:
DevTools
Component:
Performance Tools (Profiler/Timeline)
Platform:
x86
macOS
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED DUPLICATE of bug 1145784

People

(Reporter: bgrins, Unassigned)

References

Details

STR:

Select a region in the overview pane
Mouse down on the timeline below
While keeping the mouse down, move it up into the overview pane
Release the mouse

Notice that the selected are in the overview pane is changed, even though a mousedown never occurred.

The fix should be simple - just keep a bit to keep track of whether we are currently dragging.  Set it on mousedown and then return early on mouseup if it's not true.  Or, bind the mouseup event only once the mousedown event happens and unbind it once the mouseup happens.
Moving into the Profiler component. Filter on GUTHRIE'S WAVY CAKES.
Component: Developer Tools: Timeline → Developer Tools: Profiler
No longer depends on: 1066504
No longer depends on: 1144779
Blocks: perf-tool-papercuts
No longer blocks: perf-tool-v2
Priority: -- → P2
This was fixed by Bug 1145784
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → DUPLICATE
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.