Closed Bug 1144806 Opened 5 years ago Closed 5 years ago

Rewrite test_temporary_storage.js to not depend on database size

Categories

(Core :: Storage: IndexedDB, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla40
Tracking Status
firefox40 --- fixed

People

(Reporter: janv, Assigned: janv)

Details

Attachments

(1 file, 1 obsolete file)

No description provided.
Attached patch patch (obsolete) — Splinter Review
Assignee: nobody → Jan.Varga
Status: NEW → ASSIGNED
Attachment #8579519 - Flags: review?(bent.mozilla)
Attachment #8579519 - Attachment is patch: true
Comment on attachment 8579519 [details] [diff] [review]
patch

Review of attachment 8579519 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/indexedDB/test/unit/test_temporary_storage.js
@@ +16,2 @@
>  
> +  const tempStorageLimitKB = 1024 * 10;

Too big :)

@@ +137,5 @@
> +      }
> +      request.onsuccess = grabEventAndContinueHandler;
> +      event = yield undefined;
> +
> +      is(event.type, "success", "Got correct event type");

Need to close the database here or else windows will choke trying to delete files that are in use.
Attachment #8579519 - Flags: review?(bent.mozilla) → review+
Attached patch updated patchSplinter Review
Attachment #8579519 - Attachment is obsolete: true
Attachment #8579585 - Flags: review+
https://hg.mozilla.org/mozilla-central/rev/daf81d9bbb7e
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
Flags: needinfo?(Jan.Varga)
You need to log in before you can comment on or make changes to this bug.