Change JS_DefineProperty APIs to treat getter/setter=nullptr as indicating class getter/setter ops only for data properties

RESOLVED FIXED in Firefox 39

Status

()

defect
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: jorendorff, Assigned: jorendorff)

Tracking

unspecified
mozilla39
x86_64
Linux
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox39 fixed)

Details

Attachments

(1 attachment)

In particular, when JSPROP_GETTER is present but JSPROP_SETTER is not, and the setter argument is null, we should not use the class setter.

This is part of shifting all DefineProperty APIs toward standard semantics, so blocks bug 1125624.
Assignee

Updated

4 years ago
Blocks: 1125624
Assignee

Updated

4 years ago
Assignee: nobody → jorendorff
Status: NEW → ASSIGNED
Attachment #8579966 - Flags: review?(jwalden+bmo) → review+
https://hg.mozilla.org/mozilla-central/rev/3e8cc3750b9c
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla39
You need to log in before you can comment on or make changes to this bug.