1144819 - Change JS_DefineProperty APIs to treat getter/setter=nullptr as indicating class getter/setter ops only for data properties

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Jason Orendorff [:jorendorff]]

In particular, when JSPROP_GETTER is present but JSPROP_SETTER is not, and the setter argument is null, we should not use the class setter.

This is part of shifting all DefineProperty APIs toward standard semantics, so blocks bug 1125624.

Comment 1

[Jason Orendorff [:jorendorff]]

Attachment: Change JS_DefineProperty APIs to treat gette and sette as indicating class getter/setter ops only for data properties

Comment 2

[Jason Orendorff [:jorendorff]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=d6f8b44b10b9

Comment 3

[Jason Orendorff [:jorendorff]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/7ebc76a450c3

Comment 4

[Phil Ringnalda (:philor)]

Backed out that whole push in https://hg.mozilla.org/integration/mozilla-inbound/rev/c3638d994edd for massive widespread bustage, https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=7613fc978d36&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception - something must have changed out from under you.

Comment 5

[Jason Orendorff [:jorendorff]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/3e8cc3750b9c

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/3e8cc3750b9c