1144830 - [Camera] Multiple volume-rocker presses ignores countdown timer and takes pictures during countdown

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Camera, defect)

Description

[Joshua Mitchell (Inactive)]

Attachment: logcat_20150318_1239.txt

Description:
In the camera app, there is an option to have a delay, countdown timer. Due to a new feature change the volume rocker will now take pictures. If the count-down timer is counting down and the volume rocker is pressed, the camera app will ignore that the count-down is going and take a picture. Pressing the on screen shutter button while a countdown is going does NOT take a picture.
It seems that the volume rocker functionality should be disabled for the duration of the countdown.


Repro Steps:
1) Update a Flame to 20150318055750
2) Launch Camera App
3) Access settings and set the countdown timer to 10 seconds
4) Tap the volume rocker or shutter button once to start the countdown timer
5) While the timer counts down hit the volume rocker bar a few times

Actual:
Multiple pictures are taken / countdown timer is ignored

Expected:
Volume rocker will not function during countdown 

Environmental Variables:
Device: Flame Master
Build ID: 20150318055750
Gaia: b8051d370ddf4e5bd8e7d8a19fb9eeb5fd6ffb39
Gecko: 41a61514461e
Gonk: b83fc73de7b64594cd74b33e498bf08332b5d87b
Version: 39.0a1 (Master)
Firmware Version: v188-1
User Agent: Mozilla/5.0 (Mobile; rv:39.0) Gecko/39.0 Firefox/39.0

Repro frequency: 7/7
See attached: logcat

Comment 1

[Joshua Mitchell (Inactive)]

The volume rocker = camera shutter 'feature' is not implemented in 2.2 

Device: Flame 2.2 (KK - Nightly - Full Flash - 319mem)
Build ID: 20150318055750
Gaia: b8051d370ddf4e5bd8e7d8a19fb9eeb5fd6ffb39
Gecko: 41a61514461e
Gonk: b83fc73de7b64594cd74b33e498bf08332b5d87b
Version: 39.0a1 (Master)
Firmware Version: v188-1
User Agent: Mozilla/5.0 (Mobile; rv:39.0) Gecko/39.0 Firefox/39.0

Comment 2

[GitHub Autolander Bot]

Attachment: [gaia] wilsonpage:1144830 > mozilla-b2g:master

Comment 4

[Justin D'Arcangelo [:justindarc]]

Comment on attachment 8580224 [details] [review]
[gaia] wilsonpage:1144830 > mozilla-b2g:master

One minor nit about a naming convention, otherwise looks good. If you agree with me on that, go ahead and change it. Thanks for cleaning up ConfirmController to be more consistent with the other controllers :-)

Comment 5

[GitHub Autolander Bot]

https://github.com/mozilla-b2g/gaia/pull/28991

Autolander could not land the pull request due to not having collaborator rights. This is possibly due to a tree closure. Please check the tree status and request checkin again once the tree is open.

Comment 6

[GitHub Autolander Bot]

Attachment: [gaia] wilsonpage:1144830-v2.2 > mozilla-b2g:v2.2

Comment 7

[Wilson Page [:wilsonpage]]

Comment on attachment 8582374 [details] [review]
[gaia] wilsonpage:1144830-v2.2 > mozilla-b2g:v2.2

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #):
[User impact] if declined: Volume rocker will toggle volume and not capture
[Testing completed]:
[Risk to taking this patch] (and alternatives if risky): New feature, moderate risk.
[String changes made]: None

Comment 8

[Wilson Page [:wilsonpage]]

Comment on attachment 8582374 [details] [review]
[gaia] wilsonpage:1144830-v2.2 > mozilla-b2g:v2.2

Patch currently layered on top of bug 1137918's v2.2 patch.

Comment 9

[Wilson Page [:wilsonpage]]

Comment on attachment 8580224 [details] [review]
[gaia] wilsonpage:1144830 > mozilla-b2g:master

For some reason automated tests aren't running for this patch so not sure if I can land.

Comment 10

[bhavana bajaj [:bajaj]]

Wilson, since we have not uplifted other vloume-rocker related changes, I am guessing this one isn't needed on 2.2 as well, so minusing the approval.

Please feel free to NI/ping me if I misunderstood anything and we need to land this.

Comment 12

[Wilson Page [:wilsonpage]]

(In reply to bhavana bajaj [:bajaj] from comment #10)
> Wilson, since we have not uplifted other vloume-rocker related changes, I am
> guessing this one isn't needed on 2.2 as well, so minusing the approval.
> 
> Please feel free to NI/ping me if I misunderstood anything and we need to
> land this.

That sound correct. Thanks :)

Comment 13

[Wilson Page [:wilsonpage]]

Comment on attachment 8580224 [details] [review]
[gaia] wilsonpage:1144830 > mozilla-b2g:master

LANDED https://github.com/mozilla-b2g/gaia/commit/0e7c8ade48129b3e03c5de8ae0452fd1f756535c

Comment 14

[Coler]

This issue has been verified successfully on Flame 3.0.The STR is same as Comment 0.
But bug#1147789 still exists on Flame 3.0. Wilson, could you help to check it?
Reproduce rate:0/5.
Attachment:Verify_Flame3.0.mp4

Build version:

Device: Flame3.0 build(Pass)
Build ID               20150401160204
Gaia Revision          4bb3a933bd805e8df1e11827cb247754c3565b0b
Gaia Date              2015-04-01 02:06:11
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/e044f4d172e2
Gecko Version          40.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150401.193001
Firmware Date          Wed Apr  1 19:30:12 EDT 2015
Bootloader             L1TC000118D0

Comment 15

[Coler]

Attachment: Verify_Flame3.0.mp4

Comment 16

[Joshua Mitchell (Inactive)]

Additionally, Bug 1144855  is partially fixed - the volume rocker no longer takes additional video when reviewing a camera - video attachment; however, it also does not adjust the volume

Comment 17

[Wilson Page [:wilsonpage]]

You're right, thanks for the heads up. I've reopened bug 1147789 and submitted a new patch.