Closed Bug 1144831 Opened 5 years ago Closed 5 years ago

Remove the HandleLongTapUp method from GeckoContentController

Categories

(Core :: Panning and Zooming, defect)

All
Gonk (Firefox OS)
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla39
Tracking Status
firefox39 --- fixed

People

(Reporter: kats, Assigned: kats)

Details

Attachments

(1 file)

While investigating bug 1142437 I noticed that there is a scenario where we the APZ code can dispatch a click event before the corresponding touchend - this happens when the user does a long-press, and the contextmenu or mozlongtap events are not preventDefaulted. Generally dispatching the click before the touchend can be problematic (at one point facebook had issues with this) and for consistency we should always dispatch the click after the touchend.

With this in mind, and also nothing that the HandleLongTapUp controller notification does nothing *but* dispatch a click, we can just get rid of HandleLongTapUp entirely and re-use the HandleSingleTap code.
Attachment #8579579 - Flags: review?(botond) → review+
https://hg.mozilla.org/mozilla-central/rev/101eb8adcec9
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla39
You need to log in before you can comment on or make changes to this bug.