Closed
Bug 1144834
Opened 11 years ago
Closed 11 years ago
Move resetBufferedGrayRoots to GCRuntime
Categories
(Core :: JavaScript: GC, defect)
Core
JavaScript: GC
Tracking
()
RESOLVED
FIXED
mozilla39
| Tracking | Status | |
|---|---|---|
| firefox39 | --- | fixed |
People
(Reporter: terrence, Assigned: terrence)
References
Details
Attachments
(1 file)
|
4.51 KB,
patch
|
jonco
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Attachment #8579568 -
Flags: review?(jcoppeard)
|
||
Comment 1•11 years ago
|
||
Comment on attachment 8579568 [details] [diff] [review]
2.8_move_resetBufferedGrayRoots_to_GCRuntime-v0.diff
Review of attachment 8579568 [details] [diff] [review]:
-----------------------------------------------------------------
::: js/src/gc/RootMarking.cpp
@@ +580,5 @@
>
> + // If we OOMed while buffering gray roots, clear out the buffers since we
> + // are not going to be using them anyway.
> + if (grayBufferState == GrayBufferState::Failed)
> + resetBufferedGrayRoots();
The previous sections might be clearer as:
if (marker.bufferingGrayRootsFailed) {
grayBufferState = GrayBufferState::Failed;
resetBufferedGrayRoots();
}
Attachment #8579568 -
Flags: review?(jcoppeard) → review+
|
Assignee | |
Comment 2•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
status-firefox39:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla39
You need to log in
before you can comment on or make changes to this bug.
Description
•