Move resetBufferedGrayRoots to GCRuntime

RESOLVED FIXED in Firefox 39

Status

()

RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: terrence, Assigned: terrence)

Tracking

Trunk
mozilla39
Points:
---

Firefox Tracking Flags

(firefox39 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

4 years ago
Created attachment 8579568 [details] [diff] [review]
2.8_move_resetBufferedGrayRoots_to_GCRuntime-v0.diff
Attachment #8579568 - Flags: review?(jcoppeard)
Comment on attachment 8579568 [details] [diff] [review]
2.8_move_resetBufferedGrayRoots_to_GCRuntime-v0.diff

Review of attachment 8579568 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/gc/RootMarking.cpp
@@ +580,5 @@
>  
> +    // If we OOMed while buffering gray roots, clear out the buffers since we
> +    // are not going to be using them anyway.
> +    if (grayBufferState == GrayBufferState::Failed)
> +        resetBufferedGrayRoots();

The previous sections might be clearer as:

if (marker.bufferingGrayRootsFailed) {
  grayBufferState = GrayBufferState::Failed;
  resetBufferedGrayRoots();
}
Attachment #8579568 - Flags: review?(jcoppeard) → review+
https://hg.mozilla.org/mozilla-central/rev/a31a1564808a
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
status-firefox39: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla39
You need to log in before you can comment on or make changes to this bug.