Closed
Bug 1144842
Opened 7 years ago
Closed 6 years ago
Require |--enable-profiling| when building non-debug DMD builds on OS X
Categories
(Core :: DMD, defect)
Tracking
()
RESOLVED
FIXED
mozilla46
Tracking | Status | |
---|---|---|
firefox46 | --- | fixed |
People
(Reporter: erahm, Assigned: n.nethercote)
References
Details
Attachments
(4 files)
1.10 KB,
patch
|
erahm
:
review+
|
Details | Diff | Splinter Review |
2.03 KB,
patch
|
glandium
:
review+
|
Details | Diff | Splinter Review |
3.46 KB,
patch
|
glandium
:
review+
|
Details | Diff | Splinter Review |
1.71 KB,
patch
|
glandium
:
review+
|
Details | Diff | Splinter Review |
+++ This bug was initially created as a clone of Bug #995443 +++ In bug 995443 we determined that |ac_add_options --enable-profiling| is needed in your .mozconfig when enabling DMD on non-debug builds, otherwise you will get runtime crashes. We should add a config check to prevent building w/o that option (or maybe to just make it implied if |--enable-dmd| is specified).
![]() |
Assignee | |
Comment 1•6 years ago
|
||
Attachment #8709205 -
Flags: review?(erahm)
![]() |
Assignee | |
Updated•6 years ago
|
Assignee: nobody → n.nethercote
Status: NEW → ASSIGNED
Reporter | ||
Comment 2•6 years ago
|
||
Comment on attachment 8709205 [details] [diff] [review] Require --enable-profiling for non-debug DMD builds on OS X Review of attachment 8709205 [details] [diff] [review]: ----------------------------------------------------------------- r=me.
Attachment #8709205 -
Flags: review?(erahm) → review+
![]() |
Assignee | |
Comment 3•6 years ago
|
||
Try looks good: https://treeherder.mozilla.org/#/jobs?repo=try&revision=e6834fbf1761
![]() |
Assignee | |
Comment 4•6 years ago
|
||
Attachment #8710790 -
Flags: review?(mh+mozilla)
![]() |
Assignee | |
Comment 5•6 years ago
|
||
This requires moving the --enable-dmd code earlier, before MOZ_PROFILING starts being used.
Attachment #8710791 -
Flags: review?(mh+mozilla)
![]() |
Assignee | |
Comment 6•6 years ago
|
||
It doesn't make sense to enable DMD in the JS shell.
Attachment #8710792 -
Flags: review?(mh+mozilla)
Updated•6 years ago
|
Attachment #8710790 -
Flags: review?(mh+mozilla) → review+
Updated•6 years ago
|
Attachment #8710791 -
Flags: review?(mh+mozilla) → review+
Updated•6 years ago
|
Attachment #8710792 -
Flags: review?(mh+mozilla) → review+
![]() |
Assignee | |
Comment 7•6 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/0517f538cdf85acc421736e65b3febab41d9706d Bug 1144842 (part 1) - Don't use MOZ_PROFILING before all the places it can be set. r=glandium. https://hg.mozilla.org/integration/mozilla-inbound/rev/16b98426457ca48e93c896bf4cc0d992b59d8832 Bug 1144842 (part 2) - Make --enable-dmd imply --enable-profiling. r=glandium. https://hg.mozilla.org/integration/mozilla-inbound/rev/29271e7d0c2362109080fb8cfbbbbadba0c4f0f6 Bug 1144842 (part 3) - Remove --enable-dmd code from js/src/configure.in. r=glandium.
Comment 8•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/0517f538cdf8 https://hg.mozilla.org/mozilla-central/rev/16b98426457c https://hg.mozilla.org/mozilla-central/rev/29271e7d0c23
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox46:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla46
You need to log in
before you can comment on or make changes to this bug.
Description
•