Closed Bug 1144842 Opened 5 years ago Closed 4 years ago

Require |--enable-profiling| when building non-debug DMD builds on OS X

Categories

(Core :: DMD, defect)

Product:
Core
Component:
DMD
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla46
Tracking Flags:
Tracking Status
firefox46 --- fixed

People

(Reporter: erahm, Assigned: njn)

References

Details

Attachments

(4 files)

Require --enable-profiling for non-debug DMD builds on OS X
1.10 KB, patch
erahm
: review+
Details | Diff | Splinter Review
(part 1) - Don't use MOZ_PROFILING before all the places it can be set
2.03 KB, patch
glandium
: review+
Details | Diff | Splinter Review
(part 2) - Make --enable-dmd imply --enable-profiling
3.46 KB, patch
glandium
: review+
Details | Diff | Splinter Review
(part 3) - Remove --enable-dmd code from js/src/configure.in
1.71 KB, patch
glandium
: review+
Details | Diff | Splinter Review 
+++ This bug was initially created as a clone of Bug #995443 +++

In bug 995443 we determined that |ac_add_options --enable-profiling| is needed in your .mozconfig when enabling DMD on non-debug builds, otherwise you will get runtime crashes.

We should add a config check to prevent building w/o that option (or maybe to just make it implied if |--enable-dmd| is specified).
Assignee: nobody → n.nethercote
Status: NEW → ASSIGNED
Comment on attachment 8709205 [details] [diff] [review]
Require --enable-profiling for non-debug DMD builds on OS X

Review of attachment 8709205 [details] [diff] [review]:
-----------------------------------------------------------------

r=me.
Attachment #8709205 - Flags: review?(erahm) → review+
This requires moving the --enable-dmd code earlier, before MOZ_PROFILING starts
being used.
Attachment #8710791 - Flags: review?(mh+mozilla)
It doesn't make sense to enable DMD in the JS shell.
Attachment #8710792 - Flags: review?(mh+mozilla)
Attachment #8710790 - Flags: review?(mh+mozilla) → review+
Attachment #8710791 - Flags: review?(mh+mozilla) → review+
Attachment #8710792 - Flags: review?(mh+mozilla) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/0517f538cdf85acc421736e65b3febab41d9706d
Bug 1144842 (part 1) - Don't use MOZ_PROFILING before all the places it can be set. r=glandium.

https://hg.mozilla.org/integration/mozilla-inbound/rev/16b98426457ca48e93c896bf4cc0d992b59d8832
Bug 1144842 (part 2) - Make --enable-dmd imply --enable-profiling. r=glandium.

https://hg.mozilla.org/integration/mozilla-inbound/rev/29271e7d0c2362109080fb8cfbbbbadba0c4f0f6
Bug 1144842 (part 3) - Remove --enable-dmd code from js/src/configure.in. r=glandium.
https://hg.mozilla.org/mozilla-central/rev/0517f538cdf8
https://hg.mozilla.org/mozilla-central/rev/16b98426457c
https://hg.mozilla.org/mozilla-central/rev/29271e7d0c23
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox46: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla46
You need to log in before you can comment on or make changes to this bug.