1144897 - checkout_tools should use bundles

Status: RESOLVED INCOMPLETE

(Release Engineering :: General, defect)

Comment 1

[Rail Aliiev [:rail]]

Attachment: bundles.diff

I generated the bundles by https://hg.mozilla.org/build/braindump/rev/573fbe04db08, which should be automated as well.

Comment 2

[Rail Aliiev [:rail]]

Comment on attachment 8579623 [details] [diff] [review]
bundles.diff

remote:   https://hg.mozilla.org/build/puppet/rev/d1edd1224e69
remote:   https://hg.mozilla.org/build/puppet/rev/5b73832a3024

Comment 3

[Nick Thomas [:nthomas] (UTC+12)]

[[e-mail] log]$ cat runner.log
2015-03-18 21:03:16,293 - INFO - iteration 1
Traceback (most recent call last):
  File "<string>", line 1, in <module>
IOError: [Errno 13] Permission denied: '/etc/instance_metadata.json'

Comment 4

[Nick Thomas [:nthomas] (UTC+12)]

The mode of /etc/instance_metadata.json is 600, despite examples of 'chmod 644' in puppet/modules/instance_metadata/templates/*. The task appears to be running as cltbld. 

Backing out for next golden AMI generation:
https://hg.mozilla.org/build/puppet/rev/4f5fd29e86a8
https://hg.mozilla.org/build/puppet/rev/59ad3b18e9bd

Working on killing bad golden AMIs and the instances running them.

Comment 5

[Nick Thomas [:nthomas] (UTC+12)]

Cleaned up the 4 variations for build/try and usw2/use1.

Comment 6

[Rail Aliiev [:rail]]

Attachment: instance_metadata_chmod.diff

It turns out we have a bunch of work arounds to chmod the file instead of fixing the root close. Let's do eet! This happens because tempfile.mkstemp()'s default is 600.

Comment 7

[Morgan Phillips [:mrrrgn]]

Comment on attachment 8580014 [details] [diff] [review]
instance_metadata_chmod.diff

Makes sense!

Comment 8

[Rail Aliiev [:rail]]

Comment on attachment 8580014 [details] [diff] [review]
instance_metadata_chmod.diff

https://hg.mozilla.org/build/puppet/rev/05c4c8653bbf

Comment 9

[Rail Aliiev [:rail]]

Comment on attachment 8579623 [details] [diff] [review]
bundles.diff

Take 2!

remote:   https://hg.mozilla.org/build/puppet/rev/e23ce2e2a677
remote:   https://hg.mozilla.org/build/puppet/rev/d87126cde406

Comment 10

[Rail Aliiev [:rail]]

BTW, just found this 

2015-03-19 08:00:39,158 - DEBUG - tasks: ['0-checkout_tools', '00-instance_metadata', '1-cleanslate', '1-cleanup', '1-mig_agent', '1-purge_builds', '3-config_mockbuild', '3-populate_shared_repos', '3-update_shared_repos', '4-buildbot.py', '99-post_flight']

00-instance_metadata runs after 0-checkout_tools, this is why the mode was not consistent.

I'm going to file another bug to fix that.

Comment 11

[Rail Aliiev [:rail]]

bundleclone should handle this