1144943 - Video snippet template (above search bar) - with Sharing Functionality

Status: RESOLVED FIXED

(Snippets :: Service, defect)

Description

[Fabio Rios [:frios]]

This request is the same as request in "Bug 1140456 - Video snippet template (above search bar)" however it includes sharing functionality. You can mimic sharing functionality as it appears here: https://snippets.mozilla.com/admin/base/snippet/4748/

This will launch with the Firefox Growth Campaign on May 12th.

Wiki: https://wiki.mozilla.org/Firefox_Growth_Campaign_2015

Comment 1

[Fabio Rios [:frios]]

checking up on this. Will this be ready by May 20th to allow time to test in prep for June launch?

Comment 2

[Fabio Rios [:frios]]

Cory, can this be modified to allow different file types rather than just a video. In other words we could upload a graphic instead of a video to used as a logo replacement, or we might not include anything else and just leave the about:home Firefox logo? Let's discuss during our meeting.

Comment 3

[Cory Price [:ckprice] (bugmail disabled, NI me!)]

Design direction:

Show video on top.

Show existing share look/feel on the bottom (without the pop animation e.g. https://snippets.allizom.org/show/60/)

Comment 4

[Cory Price [:ckprice] (bugmail disabled, NI me!)]

Sample: https://snippets.allizom.org/show/87/

View: http://cl.ly/image/2A0H2T3v2c3p

Changes copy once you have clicked Share: http://cl.ly/image/2Q0n3y3V470F

Comment 5

[Cory Price [:ckprice] (bugmail disabled, NI me!)]

Any feedback?

Comment 6

[Fabio Rios [:frios]]

Attachment: Untitled-2.jpg

Cory, it works great, but there is a glitch while loading. The Firefox logo shifts to the bottom of the page, before shifting back up, and finally fading into the video. See attached screen shot.

Entire glitch is over 1 second.

Comment 7

[Jean Collings]

+1 to Frios comment. Liking the look and feel!

Comment 8

[Giorgos Logiotatidis [:giorgos]]

(In reply to Fabio Rios [:frios] from comment #6)
> Created attachment 8606057 [details]
> Untitled-2.jpg
> 
> Cory, it works great, but there is a glitch while loading. The Firefox logo
> shifts to the bottom of the page, before shifting back up, and finally
> fading into the video. See attached screen shot.
> 
> Entire glitch is over 1 second.

This is a preview artifact caused by the assets  being loaded synchronously. The assets are larger in size compared to the average size of other snippets so you get this glitch while waiting for everything to load. Normally snippets are loaded in the background and get instantly shown to the user.

Comment 9

[Fabio Rios [:frios]]

(In reply to Giorgos Logiotatidis [:giorgos] from comment #8)
> (In reply to Fabio Rios [:frios] from comment #6)
> > Created attachment 8606057 [details]
> > Untitled-2.jpg
> > 
> > Cory, it works great, but there is a glitch while loading. The Firefox logo
> > shifts to the bottom of the page, before shifting back up, and finally
> > fading into the video. See attached screen shot.
> > 
> > Entire glitch is over 1 second.
> 
> This is a preview artifact caused by the assets  being loaded synchronously.
> The assets are larger in size compared to the average size of other snippets
> so you get this glitch while waiting for everything to load. Normally
> snippets are loaded in the background and get instantly shown to the user.

Am I interpreting correctly... that this is only experienced here in the staging preview? If so, all looks good to me!

Comment 10

[Giorgos Logiotatidis [:giorgos]]

Yes it is experienced on preview, on both stage and production preview.

Comment 11

[Giorgos Logiotatidis [:giorgos]]

Merged:
https://github.com/mozilla/snippets/commit/d89a8563b6b847b49eef1c2a434f3a38583c5b23

Template:
https://snippets.mozilla.com/admin/base/snippettemplate/36/

Thanks Cory!