Closed
Bug 1144962
Opened 9 years ago
Closed 9 years ago
We should prune some unused sipcc code
Categories
(Core :: WebRTC: Signaling, defect)
Core
WebRTC: Signaling
Tracking
()
RESOLVED
FIXED
mozilla39
| Tracking | Status | |
|---|---|---|
| firefox39 | --- | fixed |
People
(Reporter: bwc, Assigned: bwc)
Details
Attachments
(3 files, 1 obsolete file)
There's a bunch of stuff still in sipcc that we do not use, and have no plan of using.
|
Assignee | |
Comment 1•9 years ago
|
||
/r/5767 - Bug 1144962 - Part 1: Delete most setters in sipcc. /r/5769 - Bug 1144962 - Part 2: Remove some wrapper code in sipcc /r/5771 - Bug 1144962 - Part 3: Remove more unused code, and some outdated comments. Pull down these commits: hg pull review -r 80f5fb9ad3bdc320c302dce99054fe9466235131
|
|
Assignee | |
Comment 2•9 years ago
|
||
Comment on attachment 8580358 [details] MozReview Request: bz://1144962/bwc Unfortunately, reviewboard goes off the rails on some of these diffs. I promise I was only bulk deleting stuff. https://treeherder.mozilla.org/#/jobs?repo=try&revision=7f3ac2e252b1
Attachment #8580358 -
Flags: review?(martin.thomson)
|
||
Comment 3•9 years ago
|
||
Comment on attachment 8580358 [details] MozReview Request: bz://1144962/bwc https://reviewboard.mozilla.org/r/5765/#review4725
Attachment #8580358 -
Flags: review?(martin.thomson) → review+
|
|
Assignee | |
Comment 4•9 years ago
|
||
Trying to clean up after an include-what-you-use violation. https://treeherder.mozilla.org/#/jobs?repo=try&revision=d1ad0b47f583
|
|
Assignee | |
Updated•9 years ago
|
Flags: needinfo?(docfaraday)
|
|
Assignee | |
Comment 5•9 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/6deef776437b https://hg.mozilla.org/integration/mozilla-inbound/rev/c5c158a9728d https://hg.mozilla.org/integration/mozilla-inbound/rev/badfefdddfc9
Flags: needinfo?(docfaraday)
https://hg.mozilla.org/mozilla-central/rev/6deef776437b https://hg.mozilla.org/mozilla-central/rev/c5c158a9728d https://hg.mozilla.org/mozilla-central/rev/badfefdddfc9
Assignee: nobody → docfaraday
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox39:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla39
|
|
Assignee | |
Comment 7•9 years ago
|
||
Attachment #8580358 -
Attachment is obsolete: true
Attachment #8619808 -
Flags: review+
Attachment #8619809 -
Flags: review+
Attachment #8619810 -
Flags: review+
|
|
Assignee | |
Comment 8•9 years ago
|
||
|
|
Assignee | |
Comment 9•9 years ago
|
||
|
|
Assignee | |
Comment 10•9 years ago
|
||
You need to log in
before you can comment on or make changes to this bug.
Description
•