1144977 - FontFace objects should not be included in more than one loadingdone/loadingerror event's fontfaces list

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[Cameron McCormack (:heycam)]

When a FontFaceSet finishes loading, it should dispatch loadingdone/loadingerror events listing only the FontFace objects that finished loading since the last loadingdone/loadingerror events were dispatched.

Comment 1

[Cameron McCormack (:heycam)]

Attachment: test

This test should output:

adding first font
loadingdone: 1 FontFace objects
adding second font
loadingdone: 1 FontFace objects

but instead currently outputs:

adding first font
loadingdone: 1 FontFace objects
adding second font
loadingdone: 2 FontFace objects

Comment 2

[Cameron McCormack (:heycam)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=8a2cfb716a20

Comment 3

[Cameron McCormack (:heycam)]

Attachment: Part 1: Don't include FontFace objects in more than one loadingdone/loadingerror event.

Comment 4

[Cameron McCormack (:heycam)]

Attachment: Part 2: Tests.

Comment 5

[John Daggett (:jtd)]

Comment on attachment 8580231 [details] [diff] [review]
Part 1: Don't include FontFace objects in more than one loadingdone/loadingerror event.

Review of attachment 8580231 [details] [diff] [review]:
-----------------------------------------------------------------

r+ with small nit fixed.

::: layout/style/FontFaceSet.h
@@ +225,5 @@
>    void DispatchLoadingFinishedEvent(
>                                  const nsAString& aType,
>                                  const nsTArray<FontFace*>& aFontFaces);
>  
> +  // Note: if you add new cycle collected objects to FaceRecord,

hmmm, this doesn't seem to make sense

Comment 6

[John Daggett (:jtd)]

Comment on attachment 8580232 [details] [diff] [review]
Part 2: Tests.

Looks good.

Comment 7

[Cameron McCormack (:heycam)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/cfe959cdfb21
https://hg.mozilla.org/integration/mozilla-inbound/rev/7a7b97047c76

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/cfe959cdfb21
https://hg.mozilla.org/mozilla-central/rev/7a7b97047c76