Closed
Bug 1144977
Opened 9 years ago
Closed 9 years ago
FontFace objects should not be included in more than one loadingdone/loadingerror event's fontfaces list
Categories
(Core :: CSS Parsing and Computation, defect)
Core
CSS Parsing and Computation
Tracking
()
RESOLVED
FIXED
mozilla39
Tracking | Status | |
---|---|---|
firefox39 | --- | fixed |
People
(Reporter: heycam, Assigned: heycam)
References
Details
Attachments
(3 files)
504 bytes,
text/html
|
Details | |
10.91 KB,
patch
|
jtd
:
review+
|
Details | Diff | Splinter Review |
8.61 KB,
patch
|
jtd
:
review+
|
Details | Diff | Splinter Review |
When a FontFaceSet finishes loading, it should dispatch loadingdone/loadingerror events listing only the FontFace objects that finished loading since the last loadingdone/loadingerror events were dispatched.
Assignee | ||
Comment 1•9 years ago
|
||
This test should output: adding first font loadingdone: 1 FontFace objects adding second font loadingdone: 1 FontFace objects but instead currently outputs: adding first font loadingdone: 1 FontFace objects adding second font loadingdone: 2 FontFace objects
Assignee | ||
Comment 2•9 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=8a2cfb716a20
Assignee | ||
Comment 3•9 years ago
|
||
Assignee | ||
Comment 4•9 years ago
|
||
Attachment #8580232 -
Flags: review?(jdaggett)
Comment 5•9 years ago
|
||
Comment on attachment 8580231 [details] [diff] [review] Part 1: Don't include FontFace objects in more than one loadingdone/loadingerror event. Review of attachment 8580231 [details] [diff] [review]: ----------------------------------------------------------------- r+ with small nit fixed. ::: layout/style/FontFaceSet.h @@ +225,5 @@ > void DispatchLoadingFinishedEvent( > const nsAString& aType, > const nsTArray<FontFace*>& aFontFaces); > > + // Note: if you add new cycle collected objects to FaceRecord, hmmm, this doesn't seem to make sense
Attachment #8580231 -
Flags: review?(jdaggett) → review+
Comment 6•9 years ago
|
||
Comment on attachment 8580232 [details] [diff] [review] Part 2: Tests. Looks good.
Attachment #8580232 -
Flags: review?(jdaggett) → review+
Assignee | ||
Comment 7•9 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/cfe959cdfb21 https://hg.mozilla.org/integration/mozilla-inbound/rev/7a7b97047c76
Comment 8•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/cfe959cdfb21 https://hg.mozilla.org/mozilla-central/rev/7a7b97047c76
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox39:
--- → fixed
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla39
You need to log in
before you can comment on or make changes to this bug.
Description
•