1144995 - [FFOS2.0][Woodduck][Settings]The homescreen will switch immediately without pressing "OK" button.

Status: RESOLVED WORKSFORME

(Firefox OS Graveyard :: Gaia::Settings, defect, P2)

Description

[sync-1]

DEFECT DESCRIPTION:
 ->The homescreen will switch immediately without pressing "OK" button.
 
 REPRODUCING PROCEDURES:
 ->Settings ->Homescreen ->Home screen layput ->Select a layout way
 KO:The homescreen will switch immediately without pressing "OK" button.
 当选择一种Layout之后，没有点击OK键手机直接回到切换后的桌面，OK键形同虚设。
 
 EXPECTED BEHAVIOUR:
 ->Switch after pressed "OK" button.
 
 ASSOCIATE SPECIFICATION:
 
 TEST PLAN REFERENCE:
 
 TOOLS AND PLATFORMS USED:
 
 USER IMPACT:
 
 REPRODUCING RATE:
 1/1
 
 For FT PR, Please list reference mobile's behavior:

Comment 1

[Peipei Cheng (needinfo if you need my action)]

Norry, qawanted for branch check. Thanks!

Comment 2

[sync-1]

hi mozilla:
     目前select控件大多监听blur事件，即窗口消失时触发回调函数，设置生效。无论点击OK关闭窗口，还是点击home返回关闭窗口，都会触发blur事件。
     
     是否可以在select控件中隐藏“ok”按钮或者是提供cancel机制.

Comment 3

[Shine(Leave from Mozilla)]

Attachment: Woodduck2.0&Flame3.0_video.MP4

Hi Reporter:
This problem cannot be repro on latest build of Woodduck 2.0, Flame 2.0/2.1/2.2/3.0/2.1s(512mb).
Could you please help to confirm the correct issue STR or is there any precondition step? thanks!
See attachments: Woodduck2.0&Flame3.0_video.MP4
Rate：0/10

Woodduck 2.0 build: 
Build ID               20150319050314
Gaia Revision          79f923e7205299bb4ea774ce6ce0921820e5a6bd
Gaia Date              2015-03-15 14:46:18
Gecko Revision         dd8b668bf009cf1af1ecdb90272bc828928582e0
Gecko Version          32.0
Device Name            jrdhz72_w_ff
Firmware(Release)      4.4.2
Firmware(Incremental)  1426712706
Firmware Date          Thu Mar 19 05:05:25 CST 2015

Flame 2.0 build:
Build ID               20150318000203
Gaia Revision          896803174633fc6acd3fd105f81c349b8e9b9633
Gaia Date              2015-03-10 06:32:26
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g32_v2_0/rev/3db01d6d6df5
Gecko Version          32.0
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150318.035405
Firmware Date          Wed Mar 18 03:54:15 EDT 2015
Bootloader             L1TC000118D0

Flame 2.1 build:
Build ID               20150318001207
Gaia Revision          13c85d57f49b4bfd657ff674f2b530c141c94803
Gaia Date              2015-03-17 13:31:54
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/2fbd284621e2
Gecko Version          34.0
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150318.040035
Firmware Date          Wed Mar 18 04:00:46 EDT 2015
Bootloader             L1TC000118D0

Flame 2.2 build:
Build ID               20150318002504
Gaia Revision          306772a58335ac4cad285d27c3805090a8cc6886
Gaia Date              2015-03-17 17:12:36
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/a6f5f4035ea5
Gecko Version          37.0
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150318.040534
Firmware Date          Wed Mar 18 04:05:45 EDT 2015
Bootloader             L1TC000118D0

Flame 3.0 build:
Build ID               20150318055750
Gaia Revision          b8051d370ddf4e5bd8e7d8a19fb9eeb5fd6ffb39
Gaia Date              2015-03-18 07:48:50
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/41a61514461e
Gecko Version          39.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150318.093634
Firmware Date          Wed Mar 18 09:36:44 EDT 2015
Bootloader             L1TC000118D0

2.1s_512mb build:
Build ID               20150318161205
Gaia Revision          13c85d57f49b4bfd657ff674f2b530c141c94803
Gaia Date              2015-03-17 13:31:54
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g34_v2_1s/rev/e64b1776894a
Gecko Version          34.0
Device Name            scx15_sp7715ea
Firmware(Release)      4.4.2
Firmware(Incremental)  122
Firmware Date          Thu Feb  5 12:42:58 CST 2015

Comment 4

[Peipei Cheng (needinfo if you need my action)]

Hi reporter, according to comment 3, we cannot reproduce this issue on latest woodduck mozilla build. Could you please try mozilla build out?

Link:  http://pan.baidu.com/s/1ntBOIX7
Password:  m5s3
Builds is under folder B2G_2.0_Woodduck
unzip pwd:  erT14moz

Comment 5

[sync-1]

hi mozilla:
    这个问题是关于"select"控件的处理。
      
    在settings->display->screen timeout选项中，例如当前选项是30s,当你点击1minute选项后，不点击“OK”按钮，按下home键，再进入settings->display->screen timeout会发现设置已经变为1minute,这个现象是不正常的，应该是只有用户点击"OK"键后设置才生效。
 
     目前在select控件的事件中，点击"OK"或者是"home"键，都会引发“blur”事件导致设置生效。是否可以提供一种方案select控件在按下home键时设置不生效或者是隐藏掉“OK”按钮？

Comment 6

[Pi Wei Cheng [:piwei] (inactive)]

The reporter is saying that any kind of selection in Settings app takes effect without actually hitting the OK button. For example if you go to Settings > Homescreen > select a different # of columns than current value, WITHOUT hitting OK, and go to Homescreen, you will see the changes has already been made without confirming the change.

Reporter gives another example such as Settings > Display > Screen timeout, tapping on any selection on this dropdown menu without selecting OK, the changes will take effect. (you can confirm this by tapping on Home button and come back to this settings page)

The reporter thinks that this behavior makes the OK button redundant and useless, and they would like to see an option for changes to only take effect after pressing OK.

This issue is reproducible on all branches on Flame.

Device: Flame 2.0
BuildID: 20150320000203
Gaia: 896803174633fc6acd3fd105f81c349b8e9b9633
Gecko: 4e229bde42dd
Gonk: b83fc73de7b64594cd74b33e498bf08332b5d87b
Version: 32.0 (2.0) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0

Device: Flame 2.1
BuildID: 20150320001203
Gaia: 13c85d57f49b4bfd657ff674f2b530c141c94803
Gecko: 76bf2f0c7f07
Gonk: b83fc73de7b64594cd74b33e498bf08332b5d87b
Version: 34.0 (2.1) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

Device: Flame 2.2
BuildID: 20150320002502
Gaia: c8136ef4094fc5509551ab7b1d5f6141491f00ef
Gecko: 12139abae350
Gonk: ebad7da532429a6f5efadc00bf6ad8a41288a429
Version: 37.0 (2.2) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0

Device: Flame 3.0 Master
BuildID: 20150320010204
Gaia: 8837f94418d69a0b06c1f4843b0779e2bb72165a
Gecko: 4d2d97b3ba34
Gonk: b83fc73de7b64594cd74b33e498bf08332b5d87b
Version: 39.0a1 (3.0 Master)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:39.0) Gecko/39.0 Firefox/39.0

Comment 7

[Josh Cheng [:josh]]

Hi Gary,
I think this is by design? Can we provide some suggestion for their comment 5?
Thanks!

Comment 8

[GaryChen [:GaryChen][:PYChen][:gchen][:陳柏宇]]

Hi reporter,
   Yes, this is by design.
   We have a lots of discussion about this issue since fxos project just started, and you can refer to below link as well.
   It's really hard to change this design (might patch gecko) and I don't recommend you remove 'OK' button. In some scenario this button might be useful. For example user clicks option and trigger value selector then user found the current value is more better than other, it means user doesn't want to change anything so user can click 'ok' to exit selector menu. 
   Maybe you will ask why not rename 'ok' to 'cancel', imagine that if the menu only has 'cancel' button there, it might let user more confuse when they want to 'confirm' their selection. 
   So I'd like to recommend you please don't change this design, thanks.

   [1] http://tech.mozilla.com.tw/posts/1257/select-your-selector