Closed Bug 1144998 (lightsaber-gaia) Opened 5 years ago Closed 5 years ago

(meta) lightsaber to master tracking

Categories

(Firefox OS Graveyard :: Gaia, defect, P1)

defect

Tracking

(blocking-b2g:2.5+, b2g-master fixed)

RESOLVED FIXED
2.2 S11 (1may)
blocking-b2g 2.5+
Tracking Status
b2g-master --- fixed

People

(Reporter: drs, Assigned: drs)

References

Details

(Keywords: meta, Whiteboard: [spark])

Attachments

(1 file)

This is the tracking bug for all code that we have to move from the lightsaber Gaia branch to master.
Kevin, there are some commits for enabling dev mode on the lightsaber branch. [1], [2] Should we be moving these over to master? I'm not clear on what they ever did, as there's a "reset and enable dev tools" button in the Settings app on master already.

[1] https://github.com/mozilla-b2g/gaia/commit/cf576e5773c9608e31cfe339328525c0550d7366
[2] https://github.com/mozilla-b2g/gaia/commit/587febfa24014acbcf5119349b9a82792b68b2c2
Flags: needinfo?(kgrandon)
Sure, we can land the UI pieces (after they get a review), but we should land the platform work in bug 1111961 first.
Depends on: 1111961
Flags: needinfo?(kgrandon)
Depends on: 1133990
For the addon manager, I was planning to remove the features that don't make sense on master before landing on master... That means dropping the Share button and the + button. Let me know if you want something else, and explain how it should work for users who are not using lightsaber features
Flags: needinfo?(drs)
(In reply to David Flanagan [:djf] from comment #3)
> For the addon manager, I was planning to remove the features that don't make
> sense on master before landing on master... That means dropping the Share
> button and the + button. Let me know if you want something else, and explain
> how it should work for users who are not using lightsaber features

That makes sense. Also note that, when the "Rename" button is done, we will have to exclude that as well.
Flags: needinfo?(drs)
Hi Doug, :djf told me the rename feature in settings app today. I was wondering are there any spec or more written details of it?
Flags: needinfo?(drs)
(In reply to Arthur Chen [:arthurcc] from comment #5)
> Hi Doug, :djf told me the rename feature in settings app today. I was
> wondering are there any spec or more written details of it?

Let's take this conversation to bug 1133990 comment 8.
Flags: needinfo?(drs)
Priority: -- → P1
Whiteboard: [lightsaber] → [spark]
No longer depends on: 1114676
blocking-b2g: --- → spark+
Looks like we don't need anything else in the lightsaber branch for now, so let's switch back master in our existing tooling and use it from now on.
Assignee: nobody → drs
Status: NEW → ASSIGNED
Attachment #8599427 - Flags: review?(kgrandon)
Blocks: 1157294
Comment on attachment 8599427 [details] [review]
Switch back to gaia:master.

Thanks, r=me.
Attachment #8599427 - Flags: review?(kgrandon) → review+
Landed: https://github.com/fxos/lightsaber/commit/2a0c92833b3a92917dbee3819181712ce62433d2
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Oops, this is a meta. Sorry - muscle memory closed this and I think we might still need it to track things.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Status: REOPENED → ASSIGNED
There's nothing else here that we need to do other than finish the Add-On Manager, and it's far enough along that we can resolve this bug safely.
Status: ASSIGNED → RESOLVED
Closed: 5 years ago5 years ago
Resolution: --- → FIXED
Depends on: 1149175
blocking-b2g: spark+ → 2.5+
Target Milestone: --- → 2.2 S11 (1may)
You need to log in before you can comment on or make changes to this bug.