1144998 - (lightsaber-gaia) (meta) lightsaber to master tracking

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia, defect, P1)

Description

[Doug Sherk (:drs) (inactive)]

This is the tracking bug for all code that we have to move from the lightsaber Gaia branch to master.

Comment 1

[Doug Sherk (:drs) (inactive)]

Kevin, there are some commits for enabling dev mode on the lightsaber branch. [1], [2] Should we be moving these over to master? I'm not clear on what they ever did, as there's a "reset and enable dev tools" button in the Settings app on master already.

[1] https://github.com/mozilla-b2g/gaia/commit/cf576e5773c9608e31cfe339328525c0550d7366
[2] https://github.com/mozilla-b2g/gaia/commit/587febfa24014acbcf5119349b9a82792b68b2c2

Comment 2

[Kevin Grandon :kgrandon]

Sure, we can land the UI pieces (after they get a review), but we should land the platform work in bug 1111961 first.

Comment 3

[David Flanagan [:djf]]

For the addon manager, I was planning to remove the features that don't make sense on master before landing on master... That means dropping the Share button and the + button. Let me know if you want something else, and explain how it should work for users who are not using lightsaber features

Comment 4

[Doug Sherk (:drs) (inactive)]

(In reply to David Flanagan [:djf] from comment #3)
> For the addon manager, I was planning to remove the features that don't make
> sense on master before landing on master... That means dropping the Share
> button and the + button. Let me know if you want something else, and explain
> how it should work for users who are not using lightsaber features

That makes sense. Also note that, when the "Rename" button is done, we will have to exclude that as well.

Comment 5

[Arthur Chen [:arthurcc][inactive after 6/30]]

Hi Doug, :djf told me the rename feature in settings app today. I was wondering are there any spec or more written details of it?

Comment 6

[Doug Sherk (:drs) (inactive)]

(In reply to Arthur Chen [:arthurcc] from comment #5)
> Hi Doug, :djf told me the rename feature in settings app today. I was
> wondering are there any spec or more written details of it?

Let's take this conversation to bug 1133990 comment 8.

Comment 7

[Doug Sherk (:drs) (inactive)]

Attachment: Switch back to gaia:master.

Looks like we don't need anything else in the lightsaber branch for now, so let's switch back master in our existing tooling and use it from now on.

Comment 8

[Kevin Grandon :kgrandon]

Comment on attachment 8599427 [details] [review]
Switch back to gaia:master.

Thanks, r=me.

Comment 9

[Kevin Grandon :kgrandon]

Landed: https://github.com/fxos/lightsaber/commit/2a0c92833b3a92917dbee3819181712ce62433d2

Comment 10

[Kevin Grandon :kgrandon]

Oops, this is a meta. Sorry - muscle memory closed this and I think we might still need it to track things.

Comment 11

[Doug Sherk (:drs) (inactive)]

There's nothing else here that we need to do other than finish the Add-On Manager, and it's far enough along that we can resolve this bug safely.