1145079 - [Flame] Unable to place call with one SIM card in second SIM slot

Status: VERIFIED FIXED

(Firefox OS Graveyard :: RIL, defect)

Description

[:gerard-majax]

STR:
 0. Insert one SIM card in second SIM slot
 1. Boot
 2. Place a call

Expected:
 Call is placed

Actual:
 An error about invalid phone number pops

Reproduced on several master builds, maybe since several weeks, on Flame, with multiple SIM cards.

Outgoing SIM card is properly configured to second SIM in SIM manager.

Comment 1

[Johan Lorenzo [:jlorenzo]]

[Blocking Requested - why for this release]: Major regression which can lead to a certification blocker.

Reproduced on latest master[1] but not on 2.2[2]

[1] Build ID               20150318160209
Gaia Revision          c39e15f631de80c69467fda0d4ea0bcda9e194ca
Gaia Date              2015-03-18 19:30:04
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/09f6642f7d24
Gecko Version          39.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150318.195921
Firmware Date          Wed Mar 18 19:59:32 EDT 2015
Bootloader             L1TC000118D0

[2] Build ID               20150319002500
Gaia Revision          9043c11f699c15bb6072422d1dad6518d1b5ddda
Gaia Date              2015-03-19 01:40:44
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/c0442d170bec
Gecko Version          37.0
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150319.042028
Firmware Date          Thu Mar 19 04:20:38 EDT 2015
Bootloader             L1TC000118D0

Comment 2

[Johan Lorenzo [:jlorenzo]]

Attachment: ril-enabled logcat

Comment 3

[Yeojin Chung [:YeojinC]]

There are 2 different issues with this bug. One is showing the invalid phone number error message, and the other is not making a phone call. I found the window based on the latter, but builds before the first broken build displayed the error message BEFORE the outgoing callscreen shows up and actually making a phone call.

And I double-checked on 2.2, and the issue did NOT reproduce on 2.2. However, the patch for bug 1135268 seems to be uplifted on both 2.2 and Master. But my regression window directs that the cause of this issue is bug 1135268.

===========================================
b2g-inbound Regression Window:

Last Working Environmental Variables:
Device: Flame 3.0
BuildID: 20150301215524
Gaia: 52e12d99ed1533aaa53e3bfb82e94c6b46ca5bab
Gecko: c3cf47629bb4
Version: 39.0a1 (3.0) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:39.0) Gecko/39.0 Firefox/39.0

First Broken Environmental Variables:
Device: Flame 3.0
BuildID: 20150301224624
Gaia: 52e12d99ed1533aaa53e3bfb82e94c6b46ca5bab
Gecko: 214e70c97fcc
Version: 39.0a1 (3.0) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:39.0) Gecko/39.0 Firefox/39.0

Last Working Gaia First Broken Gecko: Issue DOES reproduce 
Gaia: 52e12d99ed1533aaa53e3bfb82e94c6b46ca5bab
Gecko: 214e70c97fcc

First Broken Gaia Last Working Gecko: Issue does NOT reproduce
Gaia: 52e12d99ed1533aaa53e3bfb82e94c6b46ca5bab
Gecko: c3cf47629bb4

http://hg.mozilla.org/integration/b2g-inbound/pushloghtml?fromchange=c3cf47629bb4&tochange=214e70c97fcc

possibly caused by bug 1135268

Comment 4

[KTucker [:KTucker][Inactive 3/4/2016]]

Szu-Yu, can you take a look at this please? Looks like the landing for bug 1135268 might have caused this.

Comment 5

[Szu-Yu Chen [:aknow] (inactive)]

Sorry, my bad.  It's indeed a stupid defect cause by bug 1135268.

Because of the difference of code base, the patch applied on 2.2 is not exactly same with which on master. I've confirmed that the defect doesn't appear on 2.2.  Thus, the issue is not reproducible on 2.2

Comment 6

[Szu-Yu Chen [:aknow] (inactive)]

Attachment: Fix defect for calling isEmergencyOnly

Comment 7

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Comment on attachment 8580478 [details] [diff] [review]
Fix defect for calling isEmergencyOnly

Review of attachment 8580478 [details] [diff] [review]:
-----------------------------------------------------------------

Thank you.

Though it might require emulator support first, do you think we can add a test case for this?

Comment 8

[Szu-Yu Chen [:aknow] (inactive)]

(In reply to Hsin-Yi Tsai [:hsinyi] from comment #7)
> Comment on attachment 8580478 [details] [diff] [review]
> Fix defect for calling isEmergencyOnly
> 
> Review of attachment 8580478 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Thank you.
> 
> Though it might require emulator support first, do you think we can add a
> test case for this?

Sure.  The test might need a feature that could remove a SIM card from emulator (remove sim 1 in test case).

Comment 9

[Wesley Huang [:wesley_huang] (EPM) (NI me)]

triage: basic function should work

Comment 10

[Szu-Yu Chen [:aknow] (inactive)]

try
https://treeherder.mozilla.org/#/jobs?repo=try&revision=4acba3d3d8c1

Comment 11

[Szu-Yu Chen [:aknow] (inactive)]

https://hg.mozilla.org/integration/b2g-inbound/rev/7714372f2bf5

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/7714372f2bf5

Comment 13

[Jayme Mercado [:JMercado] (Inactive 3/4/2016)]

This issue is verified fixed on the latest Nightly Flame KK  3.0 build.

Actual Results: Calls can be made when using a single SIM in slot 2 of the phone.

Environmental Variables:
Device: Flame 3.0 KK (319MB) (Full Flash)
BuildID: 20150401010204
Gaia: 03164bd160809747e6a198e0dba1b7c3ee7789f5
Gecko: 18a8ea7c2c62
Gonk: b83fc73de7b64594cd74b33e498bf08332b5d87b
Version: 40.0a1 (3.0) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:40.0) Gecko/40.0 Firefox/40.0