Created attachment 8579956 [details] Output from |npm update| Will's grunt build output differed from mine. I then did an |npm update|, thinking perhaps the deps in package.json are unpinned, and after that my grunt build output matched his - so presumably they were. Lets: 1) Pin everything properly in package.json 2) Update pinned versions to newer, where appropriate The output from my npm update is attached.
I'm going to use npm-check-updates to make sure we're on the most recent node packages and then adjust the syntax so we're pinned to specific versions, rather than pulling minor releases without realising it.
Assignee: nobody → emorley
Updates: https://github.com/gruntjs/grunt/blob/v0.4.5/CHANGELOG https://github.com/PaulTondeur/grunt-cache-busting/compare/v0.0.10...7216c8ee316 (that sha is v0.0.11, they forgot to tag) https://github.com/gruntjs/grunt-contrib-clean/compare/v0.5.0...v0.6.0 https://github.com/gruntjs/grunt-contrib-concat/compare/v0.4.0...v0.5.1 https://github.com/gruntjs/grunt-contrib-copy/compare/v0.5.0...v0.8.0 https://github.com/gruntjs/grunt-contrib-cssmin/compare/v0.9.0...82dfd3d160 (that sha is v0.12.3, they forgot to tag) https://github.com/gruntjs/grunt-contrib-uglify/compare/v0.4.0...v0.9.1 https://github.com/yeoman/grunt-usemin/compare/v2.1.1...v3.0.0
Doing this prior to committing the output of grunt build in the treeherder repo, since I'd like to start as we mean to go on (with consistent grunt build output).
Priority: P3 → P2
Summary: The output of grunt build is not deterministic → The output of grunt build is not deterministic since node packages not pinned
Created attachment 8608106 [details] [review] Update grunt node packages & pin to specific versions
Attachment #8608106 - Flags: review?(mdoglio) → review+
Commits pushed to master at https://github.com/mozilla/treeherder https://github.com/mozilla/treeherder/commit/f2f362e430f664fed5745ea67c2ddac04ba7f835 Bug 1145083 - Remove unused grunt-filerev node package We switched to grunt-cache-busting some time ago and so no longer use grunt-filerev. https://github.com/mozilla/treeherder/commit/ee4113320963ab70ba51b4f4d288c90326d373ed Bug 1145083 - Update grunt node packages & pin to specific versions We were previously using '~' (which allows for N.N.*) and '^' (which allows for N.*.*) for the grunt node package version numbers. This meant that each person running grunt build could end up with different output, since the versions were not pinned. Instead, all packages are now pinned to a specific version - the latest currently available (which in many cases is not far off the version someone running |npm install| in a clean repo would have gotten anyway, due to the use of '^' and '~').
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.