The output of grunt build is not deterministic since node packages not pinned

RESOLVED FIXED

Status

Tree Management
Treeherder: Docs & Development
P2
normal
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: emorley, Assigned: emorley)

Tracking

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

3 years ago
Created attachment 8579956 [details]
Output from |npm update|

Will's grunt build output differed from mine.

I then did an |npm update|, thinking perhaps the deps in package.json are unpinned, and after that my grunt build output matched his - so presumably they were.

Lets:
1) Pin everything properly in package.json
2) Update pinned versions to newer, where appropriate

The output from my npm update is attached.
(Assignee)

Comment 1

3 years ago
I'm going to use npm-check-updates to make sure we're on the most recent node packages and then adjust the syntax so we're pinned to specific versions, rather than pulling minor releases without realising it.
Assignee: nobody → emorley
(Assignee)

Comment 3

3 years ago
Doing this prior to committing the output of grunt build in the treeherder repo, since I'd like to start as we mean to go on (with consistent grunt build output).
Blocks: 1056877
Priority: P3 → P2
Summary: The output of grunt build is not deterministic → The output of grunt build is not deterministic since node packages not pinned
(Assignee)

Comment 4

3 years ago
Created attachment 8608106 [details] [review]
Update grunt node packages & pin to specific versions
Attachment #8579956 - Attachment is obsolete: true
Attachment #8608106 - Flags: review?(mdoglio)
(Assignee)

Updated

3 years ago
Status: NEW → ASSIGNED
Attachment #8608106 - Flags: review?(mdoglio) → review+

Comment 5

3 years ago
Commits pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/f2f362e430f664fed5745ea67c2ddac04ba7f835
Bug 1145083 - Remove unused grunt-filerev node package

We switched to grunt-cache-busting some time ago and so no longer use
grunt-filerev.

https://github.com/mozilla/treeherder/commit/ee4113320963ab70ba51b4f4d288c90326d373ed
Bug 1145083 - Update grunt node packages & pin to specific versions

We were previously using '~' (which allows for N.N.*) and '^' (which
allows for N.*.*) for the grunt node package version numbers. This meant
that each person running grunt build could end up with different output,
since the versions were not pinned. Instead, all packages are now pinned
to a specific version - the latest currently available (which in many
cases is not far off the version someone running |npm install| in a
clean repo would have gotten anyway, due to the use of '^' and '~').
(Assignee)

Updated

3 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.