Devtools tooltips emit show/shown/hide/hidden events for all nested elements emitting these events

RESOLVED FIXED in Firefox 39

Status

RESOLVED FIXED
4 years ago
3 months ago

People

(Reporter: pbro, Assigned: pbro)

Tracking

unspecified
Firefox 39

Firefox Tracking Flags

(firefox39 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

4 years ago
See here: http://mxr.mozilla.org/mozilla-central/source/browser/devtools/shared/widgets/Tooltip.js#192

The Tooltip class re-emits all show/shown/hide/hidden events that are emitted at XUL <panel> level. But because of event propagation, any element that emits those same events within the <panel> will cause the Tooltip class to re-emit them too (this happens with <select> elements for instance).

The simple fix is to check event.target to avoid emitting unrelated events.
(Assignee)

Updated

4 years ago
Blocks: 1055181
(Assignee)

Comment 1

4 years ago
Created attachment 8580057 [details]
MozReview Request: bz://1145162/pbrosset

/r/5713 - Bug 1145162 - Prevent Tooltip class from relaying show/hide events that aren't its own; r=miker

Pull down this commit:

hg pull review -r 6818cc51a6a0459ae3de70da291d1709540cc3fd
(Assignee)

Updated

4 years ago
Attachment #8580057 - Flags: review?(mratcliffe)
(Assignee)

Comment 2

4 years ago
Comment on attachment 8580057 [details]
MozReview Request: bz://1145162/pbrosset

/r/5713 - Bug 1145162 - Prevent Tooltip class from relaying show/hide events that aren't its own; r=miker

Pull down this commit:

hg pull review -r 6818cc51a6a0459ae3de70da291d1709540cc3fd
(Assignee)

Updated

4 years ago
Assignee: nobody → pbrosset
Status: NEW → ASSIGNED
Comment on attachment 8580057 [details]
MozReview Request: bz://1145162/pbrosset

https://reviewboard.mozilla.org/r/5711/#review4801

Awesome.
Attachment #8580057 - Flags: review?(mratcliffe) → review+
(Assignee)

Comment 5

4 years ago
Thanks Mike.
Pushed to fx-team: https://hg.mozilla.org/integration/fx-team/rev/35d17c53d9d1
https://hg.mozilla.org/mozilla-central/rev/35d17c53d9d1
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
status-firefox39: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 39
(Assignee)

Comment 7

3 years ago
Comment on attachment 8580057 [details]
MozReview Request: bz://1145162/pbrosset
Attachment #8580057 - Attachment is obsolete: true
Attachment #8619815 - Flags: review+
(Assignee)

Comment 8

3 years ago
Created attachment 8619815 [details]
MozReview Request: Bug 1145162 - Prevent Tooltip class from relaying show/hide events that aren't its own; r=miker

Updated

3 months ago
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.