Closed
Bug 1145162
Opened 10 years ago
Closed 10 years ago
Devtools tooltips emit show/shown/hide/hidden events for all nested elements emitting these events
Categories
(DevTools :: Inspector, defect)
DevTools
Inspector
Tracking
(firefox39 fixed)
RESOLVED
FIXED
Firefox 39
| Tracking | Status | |
|---|---|---|
| firefox39 | --- | fixed |
People
(Reporter: pbro, Assigned: pbro)
References
Details
Attachments
(1 file, 1 obsolete file)
See here: http://mxr.mozilla.org/mozilla-central/source/browser/devtools/shared/widgets/Tooltip.js#192
The Tooltip class re-emits all show/shown/hide/hidden events that are emitted at XUL <panel> level. But because of event propagation, any element that emits those same events within the <panel> will cause the Tooltip class to re-emit them too (this happens with <select> elements for instance).
The simple fix is to check event.target to avoid emitting unrelated events.
|
Assignee | |
Comment 1•10 years ago
|
||
/r/5713 - Bug 1145162 - Prevent Tooltip class from relaying show/hide events that aren't its own; r=miker
Pull down this commit:
hg pull review -r 6818cc51a6a0459ae3de70da291d1709540cc3fd
|
|
Assignee | |
Updated•10 years ago
|
Attachment #8580057 -
Flags: review?(mratcliffe)
|
|
Assignee | |
Comment 2•10 years ago
|
||
Comment on attachment 8580057 [details]
MozReview Request: bz://1145162/pbrosset
/r/5713 - Bug 1145162 - Prevent Tooltip class from relaying show/hide events that aren't its own; r=miker
Pull down this commit:
hg pull review -r 6818cc51a6a0459ae3de70da291d1709540cc3fd
|
|
Assignee | |
Comment 3•10 years ago
|
||
Also, a try build: https://treeherder.mozilla.org/#/jobs?repo=try&revision=6b3f69977997
|
|
Assignee | |
Updated•10 years ago
|
Assignee: nobody → pbrosset
Status: NEW → ASSIGNED
|
||
Comment 4•10 years ago
|
||
Comment on attachment 8580057 [details]
MozReview Request: bz://1145162/pbrosset
https://reviewboard.mozilla.org/r/5711/#review4801
Awesome.
Attachment #8580057 -
Flags: review?(mratcliffe) → review+
|
|
Assignee | |
Comment 5•10 years ago
|
||
Thanks Mike.
Pushed to fx-team: https://hg.mozilla.org/integration/fx-team/rev/35d17c53d9d1
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
status-firefox39:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 39
|
|
Assignee | |
Comment 7•10 years ago
|
||
Attachment #8580057 -
Attachment is obsolete: true
Attachment #8619815 -
Flags: review+
|
|
Assignee | |
Comment 8•10 years ago
|
||
|
||
Updated•7 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•