Closed Bug 1145176 Opened 9 years ago Closed 7 years ago

Use consistent runner task numerical prefix

Categories

(Release Engineering :: General, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED INCOMPLETE

People

(Reporter: rail, Unassigned)

Details

Attachments

(1 file)

Found this:

2015-03-19 08:00:39,158 - DEBUG - tasks: ['0-checkout_tools', '00-instance_metadata', '1-cleanslate', '1-cleanup', '1-mig_agent', '1-purge_builds', '3-config_mockbuild', '3-populate_shared_repos', '3-update_shared_repos', '4-buildbot.py', '99-post_flight']


Sounds like 00-instance_metadata is supposed to run first, but it wasn't.

We can use moar prefix digits, let's say 2 like initscripts do?
Yes, I agree, this is an issue. I'll make the ordering algorithm prefer digits.
Assignee: nobody → winter2718
This will make our tasks sort the way people expect. It also handles comparisons like: 0-task > 00-task (it considers the task with extra zeros to be a "lower" ranking).
Attachment #8580804 - Flags: review?(rail)
Attachment #8580804 - Attachment mime type: text/plain → text/x-github-pull-request
Comment on attachment 8580804 [details]
https://github.com/mozilla/build-runner/pull/26/files

Comments are in the PR
Attachment #8580804 - Flags: review?(rail) → review-
(In reply to Rail Aliiev [:rail] from comment #0)
> Sounds like 00-instance_metadata is supposed to run first, but it wasn't.

Just to clarify this statement. 
`ls` lists 00-instance_metadata first, this is why I said "supposed to".
Assignee: winter2718 → nobody
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → INCOMPLETE
Component: General Automation → General
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: