Created attachment 8580132 [details] 2015-03-19-12-58-37.png Description: When you have an audio file as an attachment and you tap on it you are given the options to: Listen, Remove Audio, or Replace Audio. If you select Replace audio you would expect that you would only see options that would allow you to attach a different audio file. Instead you are given all the usual picker options. I would expect those options if the first menu instead said 'replace file' or 'replace attachment' Repro Steps: 1) Update a Flame to 20150319010201 2) Launch messages 3) Attach an audio file 4) Tap on the audio file 5) Select replace audio Actual: Non-audio related attachment methods are present Expected: Audio-specific picker options -or- A less specific replacement message Environmental Variables: Device: Flame Master Build ID: 20150319010201 Gaia: c39e15f631de80c69467fda0d4ea0bcda9e194ca Gecko: cf1060d8ce9f Gonk: b83fc73de7b64594cd74b33e498bf08332b5d87b Version: 39.0a1 (Master) Firmware Version: v188-1 User Agent: Mozilla/5.0 (Mobile; rv:39.0) Gecko/39.0 Firefox/39.0 Repro frequency: 6/6 See attached: screenshot
This issue also occurs on 2.2, 2.1 and 2.0 Device: Flame 2.2 (KK - Nightly - Full Flash - 319mem) Build ID: 20150318055750 Gaia: b8051d370ddf4e5bd8e7d8a19fb9eeb5fd6ffb39 Gecko: 41a61514461e Gonk: b83fc73de7b64594cd74b33e498bf08332b5d87b Version: 39.0a1 (Master) Firmware Version: v188-1 User Agent: Mozilla/5.0 (Mobile; rv:39.0) Gecko/39.0 Firefox/39.0 Device: Flame 2.1 (KK - Nightly - Full Flash - 319mem) Build ID: 20150318001207 Gaia: 13c85d57f49b4bfd657ff674f2b530c141c94803 Gecko: 2fbd284621e2 Gonk: b83fc73de7b64594cd74b33e498bf08332b5d87b Version: 34.0 (2.1) Firmware Version: v18D-1 User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0 Device: Flame 2.0 (KK - Nightly - Full Flash - 319mem) Build ID: 20150316000201 Gaia: 896803174633fc6acd3fd105f81c349b8e9b9633 Gecko: 2fc0c40fd074 Gonk: b83fc73de7b64594cd74b33e498bf08332b5d87b Version: 32.0 (2.0) Firmware Version: v18D-1 User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0
Hey Jenny, what do you think? IMO this is how it was specified back when we implemented this, but I'm open to change this if you think this is a good idea.
Hello Julien, I think the current way we have it is to provide more flexibility, that user can replace audio with any other format of file. But it does make more sense to show track selector for the "replace audio" function, can we make the change here? Thanks =)
Jenny, sorry I didn't understand completely what you proposed :) Also note that we have the same behavior with an image ("replace Image") and a video ("replace Video").
Hey Julien, I was saying upon tapping on "Replace audio", show the screen in step 3 directly described below: 1. Tap on attachment icon 2. Select music 3. Select a track So user can replace current audio with another audio (as the menu option text implied). The same should apply to photos, videos and contacts as you pointed out =). I'm not sure if this requires a lot of coding work or may incur other problem, if so, I have another proposal: Change the menu option text "Replace %FileType" to "Replace attachment" and "Remove %FileType" to "Remove attachment" like what we currently have for vcf attachment. So that we can solve the problem described in comment 0. What do you think?
Jenny, everything is possible, so just say whatever you think is best for the user :) Personally I think it's more flexible to give possiblity to replace with any attachment, so I'd rather do the text change instead, but it's up to you.
I'm really fine with both proposals. Let's go for the text change =) thanks!
The text change should be really easy to do for a contributor. We'd just always use the same l10n key instead of taking a different one for each types. This is in js/attachment_menu.js (remove the code to set the l10n-id depending on the type) and index.html (we can add the static l10n-id in: <button id="attachment-options-replace"></button> ).
I would like to work on this bug, if no one else is working on it currently.
Hey sure ! You can read some first steps to contribute in . When you run the SMS app in Firefox as explained in the README, you could find an example if you click on the Conversation called "Tom O'Hare": there is an audio attachment in the Composer, and if you click on it, you'll see the menu that needs to be changed here. In Firefox, clicking on the menu buttons does not work, this is expected.  https://github.com/mozilla-b2g/gaia/blob/master/apps/sms/README.md Don't hesitate to come on IRC (irc.mozilla.org) if you need any help ! Please also report quickly if you think you won't be able to work on the bug any more. Thanks a lot anyway :)
hey Syeda, still working on it or need any help?
Hello, I'm very sorry for the late reply. This is how far I have gone with fixing the bug. I tried running the app first.if I click on an attached audio file, I get a menu with 3 options : listen, remove, replace. the remove option doesn't seem to work, and replace audio brings another window that we need to change. After trying a few times I found that when remove is clicked audio actually gets removed, but the option menu stays as it is, so the user thinks there has been no change. we either need to close the option menu or show a message that the audio has been removed. I've been looking at the compose.js file of sms app. in the code for removing the attachment there is a line written AttachmentMenu.close(), but it is never reached. So i tried debugging to see which line was causing problem. There is something wrong with onContentChanged(). Found the definition of this function and somewhere around line 140 i got stuck at compose.updateType(). So the thing is , when I remove the audio, the the message type should change from mms to sms, but for some reason the type isn't changing. I've been trying to solve this problem in several ways but none worked so far.
Hey Syeda, sorry for the late reply, I got quite busy lately. I tried on my own device and it works as expected. Can I ask you which version and which device you're using? Also note that the bug here is simply to change the button's title. From comment 5: Change the menu option text "Replace %FileType" to "Replace attachment" and "Remove %FileType" to "Remove attachment" like what we currently have for vcf attachment. So that we can solve the problem described in comment 0. Please tell me if something is unclear !
Hey Syeda, Any update on this? Feel free to reach us out at irc on #gaia-messaging Thanks
Hey Syeda, Any update on this?
Mass closing of Gaia::SMS bugs. End of an era :(
Mass closing of Gaia::SMS bugs. End of an era :(