1145231 - Internal Reader View URLs should be hidden

Status: RESOLVED FIXED

(Firefox for iOS :: Reader View, defect)

Description

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

The internal Reader View URLs (currently about:reader?url= but soon http://localhost:12345/reader-view/page?url=) are shown in the location bar.

I think the location bar should be smart enough to extract the url parameter and display that instead.

Or maybe there is a better place to make the 'actual' URL available. Because we have a number of places in the code where the non-internal URL should be used. Like when sharing, or adding to history or bookmarks.

Maybe better if we have a browser.displayURL property that bridges to the browser.webView and does a transformation on it?

Comment 1

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Attachment: PR: https://github.com/mozilla/firefox-ios/pull/248

This patch introduces a `displayURL` in `Browser`. The `displayURL` is the 'real' URL that should be used for display purposes and for cases where the URL needs to be used in for example bookmarks, sharing, history.

Currently the `displayURL` only knows about our internal reader view style urls, which are of the form `http://localhost:12345/reader-mode/page?url=$REAL_URL_ENCODED`.

Comment 2

[Brian Nicholson (:bnicholson)]

Comment on attachment 8580864 [details] [review]
PR: https://github.com/mozilla/firefox-ios/pull/248

LGTM with comments.

Comment 3

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Attachment: PR: https://github.com/mozilla/firefox-ios/pull/249

Updated PR because I was not able to get the other one in a good state to merge. Dealt with the comments on the previous PR. Assuming r+ still stands so just putting this in for reference.