Closed Bug 1145282 Opened 5 years ago Closed 5 years ago

Come up with a better name for IsValidTerminatingScope

Categories

(Core :: JavaScript Engine, defect)

x86
macOS
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla39
Tracking Status
firefox39 --- fixed

People

(Reporter: bzbarsky, Assigned: bzbarsky)

Details

Attachments

(1 file)

Luke suggested IsSyntacticScope and inverting the sense.  That works for me.  Shu?
Flags: needinfo?
Flags: needinfo?
Flags: needinfo?(shu)
(In reply to Not doing reviews right now from comment #0)
> Luke suggested IsSyntacticScope and inverting the sense.  That works for me.
> Shu?

Sure, why not.
Flags: needinfo?(shu)
Assignee: nobody → bzbarsky
Status: NEW → ASSIGNED
Comment on attachment 8580458 [details] [diff] [review]
Reverse the sense of IsValidTerminatingScope and rename it to IsSyntacticScope

Review of attachment 8580458 [details] [diff] [review]:
-----------------------------------------------------------------

Much obliged!
Attachment #8580458 - Flags: review?(luke) → review+
https://hg.mozilla.org/mozilla-central/rev/163f61a32aa0
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla39
You need to log in before you can comment on or make changes to this bug.